>
> First, the CDTDatastore -updateDocumenWithId converts the TDStatus to an
> NSError using the TDStatusToNSError. The error code changes in this process
> to be equal to a CouchDB HTTP error, which has less information than a
> TDStatus error.
>
Disregard this particular concern... TDStatusToNSError is used throughout
-resolveConflictsForDocument (duh) and we are normally converting to
NSError.  But the question about logging and line 393 of
TD_Database+Insertion.m still stand.

>
>
> On Thu, May 8, 2014 at 4:28 AM, Mike Rhodes <notifications@github.com>wrote:
>
>>  This is a secure message chain, protected by Virtru.
>>
>> Yes, the main problem here is that when using the TDDatabase put method,
>> you need to copy over the attachments yourself because you'll not be
>> supplying an _attachments dictionary that the TDDatabase method requires.
>> See CDTDatastore.m#L423-L443<https://github.com/cloudant/CDTDatastore/blob/master/Classes/common/CDTDatastore.m#L423-L443>
>> .
>>
>> If at all possible, I'd use the -updateDocumentWithId:prevRev:body:inTransaction:rollback:
>> error: in CDTDatastore rather than TD_Datastore's version.
>>
>> Possibly, at the point we need to understand other instances of
>> TD_Datastores -putRevision:... that you are using. I think that, in
>> general, updates that are happening in response to calls to our API layer
>> are going to have to go via other calls in our API layer as we're starting
>> to introduce custom functionality.
>>
>> —
>> Reply to this email directly or view it on GitHub<https://github.com/cloudant/CDTDatastore/pull/22/files#r12424128>
>> .
>>
>
>