some change and test added