Allow the project to compile in Visual Studio 2013

Fixed a couple of problems that caused compilation errors in Visual Studio, and updated the Windows build instructions.
Is the zlib installer what's available at
http://gnuwin32.sourceforge.net/packages/zlib.htm ? If so, then that's zlib
version 1.2.3. My instructions use the official zlib DLL from
http://www.zlib.net/, which is version 1.2.8. That distribution doesn't
come with an installer, so there's no step where any system detection is
performed: everyone gets the same DLL and header files. The file zconf.h in
this distribution doesn't attempt to include unistd.h.


On Wed, Jun 18, 2014 at 6:55 PM, Brad Hefta-Gaub <notifications@github.com>
wrote:

> In BUILD.md:
>
> > @@ -101,67 +125,135 @@ You can use the online installer, or the offline installer. If you use the offli
> >  * Download the offline installer [here](http://download.qt-project.org/official_releases/qt/5.2/5.2.0/qt-windows-opensource-5.2.0-msvc2010_opengl-x86-offline.exe)
> >
> >  Once Qt is installed, you need to manually configure the following:
> > -* Make sure the Qt runtime DLLs are loadable (You could add the Qt\5.2.0\msvc2010_opengl\bin\ directory to your path.) - You must do this before you attempt to build because some tools for the build depend on Qt.
> > -* Set the QT_CMAKE_PREFIX_PATH environment variable to your Qt\5.2.0\msvc2010_opengl directory
> > -
> > -####zLib
> > -NOTE: zLib should configure itself correctly on install. However, sometimes zLib doesn't properly detect system components and fails to configure itself correctly. When it fails, it will not correctly set the #if HAVE_UNISTD_H at line 287 of zconf.h to #if 0... if it fails, you're build will have errors in the voxels target. You can correct this by setting the #if to 0 instead of 1, since Windows does not have unistd.h.
>
> Why did you remove this note? Have you confirmed that if you follow the
> new instructions that the zlib install will always correctly set zconf.h?
> We've seen multiple cases where the zlib installer doesn't correctly set
> this flag.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/highfidelity/hifi/pull/3041/files#r13923182>.
>



-- 
Oren Hurvitz
VP R&D
Kitely Ltd.

Email: orenh@kitely.com <ilan@kitely.com>