I think they should still get layer names. "Special cases aren't special
enough to break the rules."


On Fri, Apr 25, 2014 at 3:20 PM, axeldavy <notifications@github.com> wrote:

> In pylearn2/models/mlp.py:
>
> >      nvis : int, optional
> >          Number of "visible units" (input units). Equivalent to specifying
> > -        `input_space=VectorSpace(dim=nvis)`.
> > +        `input_space=VectorSpace(dim=
> nvis)`. Should be None if the MLP is
> > +        part of another MLP.
> > +    input_space : Space object, optional
> > +        A Space specifying the kind of input the MLP accepts. If None,
> > +        input space is specified by nvis. Should be None if the MLP is
> > +        part of another MLP.
> > +    layer_name : name of the MLP layer. Should be None if the MLP is
> > +        not part of another MLP.
>
> Does that make sense to give a layer name to a MLP?
>
> I think we should just set self.layer_name to None for MLPs,
> CompositeLayer and FlattenerLayer,
> because they are not really layers, and giving them names only add
> confusion.
>
> The code should however be modified at the correct locations to check if
> layer_name is none, and then change the debug printed info to not use it.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/lisa-lab/pylearn2/pull/646/files#r12012047>
> .
>