params improvement
test