build-sys: unify function and variable attribute spacing

From two different styles the more popular is picked to be the correct
for this package.

$ git grep -hc '_ ((*_' | awk -F: '{T+=$2} END  {print T}'
141
$ git grep -hc '_((*_'  | awk -F: '{T+=$2} END  {print T}'
168

Signed-off-by: Sami Kerola <kerolasa@iki.fi>
mcookie: use lib/randutils

The mcookie should reuse existing code, and there is definitely no need
to prefer /dev/random for this utility.  See reference for explanation
about later statement.

References: http://www.2uo.de/myths-about-urandom/
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
mcookie: allow --file option be defined multiple times

Earlier only the last option argument took effect.

Signed-off-by: Sami Kerola <kerolasa@iki.fi>
mcookie: use same variable type consistently

Signed-off-by: Sami Kerola <kerolasa@iki.fi>
mcookie: use control structure, and fix usage()

Signed-off-by: Sami Kerola <kerolasa@iki.fi>
mcookie: add --max-size option

Just in case someone wants to add entropy from device with invocation
demonstrated below.

$ mcookie --file /dev/urandom --max-size 64k

Signed-off-by: Sami Kerola <kerolasa@iki.fi>
findfs: use symbolic exit values, and tell about them in manual

And mention the exitcodes.h is meant to be used when same exit codes are
used in multiple utilities.  See reference for advice about this.

Reference: http://www.spinics.net/lists/util-linux-ng/msg08970.html
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
kill: fix coding style

The kill was deprecated at the time lot of other tools got style
unification.  Now when deprecation is lifted it is time to get kill
cleaner.  This commit does not modify code, only various spacing issues,
removal of unecessary braces, and such are dealt.

Signed-off-by: Sami Kerola <kerolasa@iki.fi>
kill: flip all comparions to be in smaller - greater order

This makes code more readable.

Signed-off-by: Sami Kerola <kerolasa@iki.fi>
kill: move magic numbers in beginning of the file

Signed-off-by: Sami Kerola <kerolasa@iki.fi>
kill: make usage() not to return

And change the function argument to be output stream.  Earlier the --help
made kill to exit with none zero value, that now is corrected.

Signed-off-by: Sami Kerola <kerolasa@iki.fi>
kill: deprecat invocation as 'pid' command name

Enabling options by renaming command is both unexpected and undocumented.
This magic is now deprecated and with remark of removal of this
functionality in future.

Signed-off-by: Sami Kerola <kerolasa@iki.fi>
kill: use control structure to pass user input to functions

This should make it easier to understand how the program works.

Signed-off-by: Sami Kerola <kerolasa@iki.fi>
kill: tell what is wrong rather than output usage()

Getting usage as error message is not specific enough.  As a user I want
to know what is wrong, and if it is unclear after error message how to
recover then I run command with --help.

Signed-off-by: Sami Kerola <kerolasa@iki.fi>
kill: add parse_arguments() function

Long main() is difficult to read, so moving argument parsing to separate
function should make sense.

Signed-off-by: Sami Kerola <kerolasa@iki.fi>
kill: move sigqueue inputs to control struct

Use of global variables is messy.  The earlier implementation also
assumed queue argument never to be textual, such as 'HUP', which now
works as one might expect.

Signed-off-by: Sami Kerola <kerolasa@iki.fi>