Have better dimension exclusions

good point

On Mon, Sep 15, 2014 at 5:04 PM, xvrl <notifications@github.com> wrote:

> In server/src/main/java/io/druid/segment/indexing/DataSchema.java:
>
> > @@ -44,7 +47,28 @@ public DataSchema(
> >    )
> >    {
> >      this.dataSource = dataSource;
> > -    this.parser = parser;
> > +
> > +    final Set<String> dimensionExclusions = Sets.newHashSet();
> > +    if (parser != null && parser.getParseSpec() != null && parser.getParseSpec().getTimestampSpec() != null) {
> > +      dimensionExclusions.add(parser.getParseSpec().getTimestampSpec().getTimestampColumn());
> > +      for (AggregatorFactory aggregator : aggregators) {
>
> why is this loop inside the if-statement?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/metamx/druid/pull/738/files#r17576888>.
>