Update spec_helper to include 'chefspec/berkshelf'

This minor change allows you to run rspec outside of strainer while
still having cookbook dependencies automatically handled by berkshelf
(which also means you can run individual chefspec tests).

Note that this change does marginally increase the time it takes to run
a strainer test.

A similar change was recently accepted in the openstack-compute
cookbook.

Change-Id: Ifbe179fbb62b7bf487e090db2c2a367d1f7cee73
Filling out initial rubocop support for metadata.rb and the Gemfile.

https://blueprints.launchpad.net/openstack-chef/+spec/lint-and-unit-testing-for-havana
Removing tailor, cleaning up metadata and Gemfile and adding TESTING.md. Will
remove the .rubocop-todo.yml later, once all the other Rubocop support is in.

Change-Id: I44e3e5002b4e152080a01a36ae08451cc2ee0751
Merge "Filling out initial rubocop support for metadata.rb and the Gemfile."
Implement Rubocop

Per the blueprint, finish implementing rubocop across the entire
cookbook, remove tailor references, and update rubocop dependency.

- Remove .tailor file
- Update Rubocop Dependency >= 0.16.0
- Update Chef Dependency to 11.8
- Add .rubocop.yml files to resources/providers
- Add resources/providers to Strainerfile
- Update all files necessary to pass rubocop

Change-Id: Icc4804b3e2a55cf6656b2e6077e36f04d959b9ef
Implements: blueprint rubocop-for-image
Move to use "get_password" instead of "{user,service,db}_password"

The user_password, service_password and db_password functions are redundant
since they simply call "secret". Creates a get_password function that will
accept a "type" of db, service or user.

All instances of these calls have been changed to call get_password

Change-Id: I5093b7b4055ef0140dfbe36f96466cf0b38efc68
Partial-Bug: #1195915
Remove Berksfile.lock from dev branches

blueprint remove-berksfile-lock-from-dev-branches

Change-Id: I7801b6fd57f4dc4fa46c8728e5177e039ee0260d
Refactor specs

Refactor the spec files to use the newer RSpec let, shared_context, and
shared_example syntax to remove redundancy and improve readability.

Remove unused and incorrect default_spec.rb file.

Change-Id: I9521cfb49e38d6b59a00ed833ffbd8129e3ac1f6
Remove ambiguity in stubbed methods in spec_helper

- Adjust the stubs in spec/spec_helper.rb to specify the appropriate
  number of expected variables.

Partial-Bug: #1271535
Change-Id: Id116db9a408bf979eb5efed5ad449825deb4e5ea
Complete Rubocop compliancy

- Ensure all files are rubocop compliant following commits
- Move to use a single .rubocop.yml file
- Update StrainerFile to reflect the single .rubocop.yml

Change-Id: I6d7b30aae4d839a2c8c2ebebbf5e9b53518db71e
Addresses: blueprint rubocop-for-image
Merge "Remove ambiguity in stubbed methods in spec_helper"
Making glance service names consistent

Right now for most cookbooks we declare resources with the name of the
service itself. So, for example, in the 'identity' cookbook, the
'keystone' service is called 'keystone'. The other cookboks follow this
same standard.

Why is this important? Things like omnibus-openstack depend on these
cookbooks having a common standard. That, and well, standards make us
all happy.

Change-Id: I3b1cb845cfb21b5e1d46feca322f3c2788431a27
Clean up cookbook for bp/clean-up-attr-for-mq-and-db

This change removes the attributes we'll be moving to openstack-common
and changes reference of those attributes to reflect new (more
consistent) namespace.

Change-Id: I981f020757eb01b53fda0bf72c7be3f414edfac8
Implements: blueprint clean-up-attr-for-mq-and-db
honor package override platform options

The api and registry recipes did not honor the package_override platform
options.  This includes some more tests.

Change-Id: Ieee6c302cb4bd62f37198867b735bc3867589853
Clean up notification settings in glance-api.conf

Currently, rabbitmq settings in glance-api.conf are hard-coded and
overrides to rabbitmq settings in environment will not be reflected in
configuration file.  This change addresses that while also only writing
rabbitmq/qpid settings when an appropriate notification strategy is
selected.

Change-Id: I9d06d4b1e030f14293d143021bd78d732adafcc2
Closes-Bug: #1273020
Add attribute and configuration for show_image_direct_url

- Add default["openstack"]["image"]["api"]["show_image_direct_url"]
  which defaults to "False"
- Add option into glance-api.conf.erb
- Added test for show_image_direct_url setting
- Adjusted README to reference attribute

Change-Id: I83cd13db1d102118d696d371d94197044abf8e94
Closes-Bug: #1274960
Upgrade/Update rubocop

Now that almost all of the rubocop blueprints have been completed, make
one final pass through all of the cookbooks ensuring they're all in
sync with each other.

- Upgrade rubocop to 0.18.1
- Fix violations caused by 0.18.1 upgrade
- Move Excludes for non-existent folders to Includes so they
  automatically cover future additions

Change-Id: If2931d371911c10787bbb2c2bf1c51881e3c4488
Implements: blueprint lint-and-unit-testing-for-havana
Add attributes for swift_enable_snet & swift_store_region

- Add default["openstack"]["image"]["api"]["swift"]["enable_snet"] attribute
- Add default["openstack"]["image"]["api"]["swift"]["store_region"] attribute
- Set defaults such that the end result doesn't change, but attributes
  can be overridden.
- Add tests for these 2 attributes
- Add README.md entries for these 2 attributes

Change-Id: I8dd10a9731f996ebe6b064d2552f9cc5a1bf468d
Closes-Bug: #1274937
Merge "Clean up notification settings in glance-api.conf"
Merge "Upgrade/Update rubocop"
Merge "Add attributes for swift_enable_snet & swift_store_region"