oops forgot the tests for conversion params