Regarding (1) - credits go to Brian from the GWT team, as I was looking
into other projects initially (JSDT Debug and Chromedevtools-Java; the
later is now not maintained actively anymore).

Regarding (2) - you are completely right. Be assured though, we do not
rearrange the methods manually - we have other useful work to do. :)

The problem is that the Dart editor uses a custom Eclipse workspace setting
regarding how methods can be ordered, which, unfortunately, is not
remembered in the project settings (Eclipse bug
https://bugs.eclipse.org/bugs/show_bug.cgi?id=231219)

So until I figure that out, I managed to reorder quite a few methods in all
files touched by me - as the method order is enforced on file save (a code
formatting setting also inherited form the Dart editor) :(
The good news is, the current reorderings *restore* the methods order of
the Dart editor, so comparison with Dart would be possible again.

James was even having a plan to do some sort of "grand-re-save" on all Java
files so that they get back to the methods order as it is in the Dart
editor source...

Finally, as for piggybacking off work from the Dart editor - this is
definitely something we would like to do.




On Wed, Feb 5, 2014 at 8:09 AM, Stephen Haberman
<notifications@github.com>wrote:

> In
> com.github.sdbg.debug.core/src/com/github/sdbg/debug/core/internal/webkit/model/BreakpointManager.java:
>
> > @@ -58,130 +58,6 @@ public BreakpointManager(WebkitDebugTarget debugTarget) {
> >      this.debugTarget = debugTarget;
> >    }
> >
> > -  private void addBreakpoint(final IBreakpoint bp) throws IOException {
>
> 1) You guys are geniuses for looking at the Dart IDE for inspiration (I
> had no idea they were working on a debugger that worked with dart compiled
> to JS).
>
> 2) I don't mean to be "that guy", but it looks like a lot of this is just
> rearranging the order of methods in the class? That makes the diff hard to
> follow, and also seems like it would make any future efforts to re-sync
> patches from Dartium over to SDBG.
>
> I know nothing about this, so perhaps you've decided on a clean break, but
> I would imagine the Dart IDE is going to have a lot of ongoing man hours
> continued to be put in to it, and it might be nice if we could continue to
> piggyback off their work by opportunistically borrowing changes and
> minimizing the conflicts.
>
> --
> Reply to this email directly or view it on GitHub<https://github.com/sdbg/sdbg/pull/3/files#r9451655>
> .
>