delete not used GerritWidgetCallback and OldGerritCallback

Change-Id: I6e708a33b28db84ffe7b93c7f80334412598b5c7
Show error message when the commentlink is configured wrongly

When the 'commentlink.<subsection-name>.match' is configured wrongly,
e.g. invalid regular expression, the change screen cannot be loaded,
and there is no error message or log.

Show an error dialog.

Bug: Issue 2514
Change-Id: Ie36fcdb0be13690cacaa64e235a08d7913dea937
Make the message of 'Cherry Picked' informative

The message reads:

 "This patchset was cherry picked to change: <Change-Id>"

This is not very informative, since the Change-Id is identical
to the current change.

A better message would be:

 "This patchset was cherry picked to branch <branch name> as commit <SHA1>"

Bug: issue 2513
Change-Id: I8bfb61b1a314cf2a985df7a571bb28e3f6cb49d4
Update 2.8.2 release notes

Change-Id: Iaf3f4ca1a45df7104e87491c5c223c4046f92ae9
Enable disabled gwtui tests

a283507bccbd408540ae1baf75eb80eb59dce031 disabled EditIteratorTest due
to gwt-test-utils uncompatibility with new GWT 2.6 release.

After fixing the compatibility problem in [1] the tests can be enabled
again.

[1] https://github.com/gwt-test-utils/gwt-test-utils/issues/62

Change-Id: I1f93e6422a1ae60d66f4d8b4abac23b6a1acb4f9
Protect reload plugin command with allow remote admin option

fd03350b9ea8af3cdf65fb8fb2367e333b252de4 introduced a new option
to disable remote plugin administration.

Require reloading plugins to be explicitly allowed with:

  plugins.allowRemoteAdmin = true

Change-Id: I2946202dd40af8b4197212fb15a488b166883d8a
Merge branch 'stable-2.8'

* stable-2.8:
  Update 2.8.2 release notes
  Make the message of 'Cherry Picked' informative
  Show error message when the commentlink is configured wrongly

Conflicts:
	gerrit-server/src/main/java/com/google/gerrit/server/change/CherryPickChange.java

Change-Id: I82a7ac51f31fec83166ecad26e65d66623d2cda4
PostReview: update and insert comments/approvals in a single step

Conflicts:
	gerrit-server/src/main/java/com/google/gerrit/server/change/PostReview.java

Change-Id: Ieab4ac0628e397495bfd8a278c879f79817ba443
Merge "Enable disabled gwtui tests"
Allow creation of persistent caches after server is started

2e1cb2b8495761a7e9abc09ebca24ca6bbf2afbe switches from Ehcache to Guava
for providing caching in Gerrit and claims that one of the advantages of
using Guava is that it enables caches to be build at any time, rather
than only at server startup. Therefore, I guess it is OK to remove the
precondition check which prevents creation of caches once the server was
started.

This enables plugins to create own persistent caches when they are
installed.

Change-Id: I28b1a140c58f9967e6d1dacd61ddd021b48c8ad5
Update 2.8.2 release notes

Change-Id: Ia580893c2c1700af9b6eddc6ee9a7916e68aa551
Bump GERRIT_VERSION to 2.8.2

Change-Id: I24e6deb8755fda9d90181db6a35397236f6c789f
Remove unused import in EditIteratorTest

Change-Id: I0758a836d5448e19f3f9a18dc70ed08fb3c1ebdf
Prevent duplicate commits in same project when uploading to refs/changes/n

Under certain circumstances, when pushing to 'refs/changes/n', the same
commit can be pushed onto multiple changes even if they are on the same
branch.

As a result of this, if the commit sha1 is used as change identifier
in the 'review' ssh command, it will fail with the error:

  'fatal: <SHA1> matches multiple patch sets.'

This commit performs the same check as when pushing to 'refs/for/branch'
to prevent this, and will show "commit already exists (in the project)"
error message to reject uploading a commit to an existing change via
`refs/changes/n` if the commit was already successfully pushed to a change
in project scope.

Bug: issue 2374
Change-Id: I1c000b2cc3e155617cdc9c295a46ce2107ec47ca
Bump version to 2.8.2 in plugin API and archetypes

Change-Id: Iaa71fe340597703b2effd60369aecd09335f4d3e
Update 2.8.2 release notes

Change-Id: I120587908d05e61a87c6058a481c6085f9586c3e
Merge branch 'stable-2.8'

* stable-2.8:
  Update 2.8.2 release notes
  Bump version to 2.8.2 in plugin API and archetypes
  Prevent duplicate commits in same project when uploading to refs/changes/n
  Bump GERRIT_VERSION to 2.8.2
  Update 2.8.2 release notes
  PostReview: update and insert comments/approvals in a single step

Conflicts:
	VERSION
	gerrit-plugin-archetype/pom.xml
	gerrit-plugin-gwt-archetype/pom.xml
	gerrit-plugin-gwtui/pom.xml
	gerrit-plugin-js-archetype/pom.xml
	gerrit-server/src/main/java/com/google/gerrit/server/change/PostReview.java
	gerrit-server/src/main/java/com/google/gerrit/server/git/ReceiveCommits.java

Change-Id: I7a611d4f9c16b8d5f3abdcd8228fca0b636d792c
Buck: Expand instructions related to setting up the path

Adding the ~/bin folder to the path in the current shell session
is not enough.  It also needs to be added globally.

Update the documentation to mention this.

Change-Id: Ic5d4cf1a02b3e52eccb6e34ba3513a69785df1f9
Fix formatting problem in buck documentation

The bullet list for API artifact repository types was not being
rendered correctly due to a missing blank line.

Also, add backticks around the version numbers in the list.

Change-Id: I58d8845acde464d223e7838160be8d222e059f2b
Add database index on patch_sets.revision

Without that index the PatchSetAccess.byRevision was always doing a
sequential table scan.

Change-Id: Ief351d56794589fa0e1804fac5a6c38fea67e23c