Wip 9639

the user_request.py change is just a minor unconnected nit.
Could be. I'll double check.
On Oct 8, 2014 1:54 AM, "John Spray" <notifications@github.com> wrote:

> In salt/srv/salt/_modules/ceph.py:
>
> >      # Interrogate the service for its FSID
> > -    config = json.loads(admin_socket(socket_path, ['config', 'get', 'fsid'], 'json'))
> > -    fsid = config['fsid']
> > +    if service_type != 'mon':
> > +        fsid = json.loads(admin_socket(socket_path, ['status'], 'json')['cluster_fsid'])
>
> So, perhaps we should have checked this earlier buuuuuut... afaict the
> 'status' commands only exist since earlier in 2014. This probably needs a
> fallback to 'config get', so that for modern clusters we're robust and for
> older clusters we hope they have a fsid in ceph.conf.
>
> This solves the mystery of why I did it the other way first time around :-)
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/ceph/calamari/pull/202/files#r18570260>.
>