2014-05-16 14:37 GMT+02:00 Andrea Antonello <notifications@github.com>:

> In
> geopaparazzispatialitelibrary/src/eu/geopaparazzi/spatialite/database/spatial/core/SpatialVectorTable.java:
>
> >        */
> > -    public void setFieldsList( HashMap<String, String> fieldName2TypeMap ) {
> > +    public void setFieldsList( HashMap<String, String> fieldName2TypeMap, String s_ROWID_PK,int i_view_read_only ) {
>
> ok, but internally in java it makes everything less readable and more
> verbose.
> if(isReadable){
>
> }
>
> is nice and clean and at the proper moment, when needed as int could be
> converted as: isReadonly ? 1 : 0
>
> That would probably also avoid lines like:
>
> if ((i_view_read_only == 0) || (i_view_read_only == 1))
>
> which I do not understand, since it should be 0 or 1, right/
>
No, if it is a SpatialTable, it would be -1

> —
> Reply to this email directly or view it on GitHub<https://github.com/geopaparazzi/geopaparazzi/pull/153/files#r12735835>
> .
>