Merge pull request #4069 from infograf768/mailcloaknewcases

Regression: Adding cases to emailcloak
( ! ) Parse error: syntax error, unexpected 'endif' (T_ENDIF) in
ROOT/administrator/modules/mod_feed/tmpl/default.php on line 111
Merge pull request #4049 from osignell/staging

Tracker #34010 fix
Revert "Updated PR - Fixed wrong call trigger after render component #2095 by brunobatista"

This reverts commit 718da9070f5925699eb683cc55d99c51e38b333a.
JAccess::checkGroup() doesn't work without an $asset

# Executive summary

JAccess::checkGroup() does not work when the optional third argument $asset is not defined. This is in stark contrast with the docblock which states that it "Defaults to the global asset node."

# Technical explanation

The root caused is a botched copy-pasted if-block spanning lines 144-147. It was copied from lines 101-104 except the last line `$asset = $rootId` was never copied. As a result, whenever $asset is empty we look into the `#__assets` table, get the root asset ID... and never use it. This causes null to always be returned, even if the given group does have the requested global privilege enabled.

The solution is to merely change line 144 from `$rootId = $assets->getRootId();` to `$asset = $assets->getRootId();` as it was intended.

# Testing

Unless you are using the affected method in your own custom code you will not be able to reproduce this issue. Apparently everyone was avoiding to use checkGroup because it's buggy but nobody figured out why.
Merge pull request #4073 from nikosdion/patch-1

JAccess::checkGroup() doesn't work without an $asset
Codestyle: Removing unneeded variable $rootId
Merge branch 'staging' into 3.4-dev
[bug][34041] JToolbar Popup button modal icon class not customizable. Fixes #4075
[imp][34026] Improved search functionality in list views. Closes #4051
[cs] Use $this->params instead $app->getTemplate(true)->params at the templates. Closes #3930
Revert "[cs] Use $this->params instead $app->getTemplate(true)->params at the templates. Closes #3930"

This reverts commit fe2509e1eb1fcf053fcd958392e447ee3b5d1ef2.

For some reason, this doesn't work in the error page.
Missing icons
code style
Merge pull request #4077 from losedk/icon

Missing icons
Update en-GB.com_categories.ini
Update en-GB.com_content.ini
[bug] Correcting missing Hathor css after previous PRs. Fixes #4078
[imp][30118] Give a notice on which update channel a user is on. Closes #3917
[bug][33932] SQL schemas updates are not applied if previous component
version didn't have schemas declaration. Fixes #3869