add tests for upgrade controller