Changing ptr::read to RawPtr::read is extremely inconvenient because, with
ptr::read, `&T` will be coerced, whereas it will *not* be when it is a
method. This introduces quite unnecessary casts. I do not wish to change it.


On Fri, Feb 14, 2014 at 10:27 PM, Corey Richardson <corey@octayn.net> wrote:

> Well the tests can't even continue, because stage1 rustc never compiles...
>
>
> On Fri, Feb 14, 2014 at 10:17 PM, Alex Crichton <notifications@github.com>wrote:
>
>> In src/libstd/vec.rs:
>>
>> >              let fill = (**repr).fill;
>> >              (**repr).fill += mem::nonzero_size_of::<T>();
>> > -            let p = to_unsafe_ptr(&((**repr).data));
>> > -            let p = p.offset(fill as int) as *mut T;
>> > +            let p = &((**repr).data) as *u8 as *mut T;
>> > +            let p = p.offset(fill as int);
>>
>> If tests didn't catch this, can you add a test as well?
>>
>> —
>> Reply to this email directly or view it on GitHub<https://github.com/mozilla/rust/pull/12282/files#r9770984>
>> .
>>
>
>