[PATCH 03/27] Pants: Add helper to "override" deps with explicit local targets:     jar_library(       name = 'name',       dependencies = [ jar('jar-with-undesirable-dep', 'org.apache', '0.1') ],       overrides = [ ':replacement-for-undesirable-dep']     )

RB_ID=264165

(sapling split of 9f163e7e6836ea42b0f62059f3d4a9a154021b9a)
[PATCH 05/27] Restrict chunking to internal targets.

Senthil and I believe this was introduced in https://reviewboard.twitter.biz/r/256435 . Recently during some internal changes we switched from chunking internal targets to concrete targets. Typically this works fine, however, there's a case where generating IDEA project files with the --idea-python option does the following:

(a) The Idea task generation task constructor registers interest in python products because the user explicitly asked for that.

(b) Thrift code generation looks to see that people explicitly asked for python thrift codegen and does that. It generates code and creates synthetic PythonLibrary targets to own the sources.

(c) This is where the issue is. Due to the recent group engine change we try to iterate over all the concrete targets, which includes PythonLibrary instances. However, PythonLibrary instances are not InternalTarget subclasses and this leads to the stack trace we see below.

The proposed fix is changing this behavior back to what it was before the refactor, which is to restrict to internal targets when making chunks.

RB_ID=273399

(sapling split of 87fc9fdfbaf15b793b5a96ff75d32bc3d93f6383)
[PATCH 06/27] Pants exists non-zero when given unknown goals.

RB_ID=273965

(sapling split of 36d17823b77c2f655787d9fa4773001c90166cbe)
[PATCH 07/27] pants docs: IDL jar docs were incomplete and misleading. remove misleading parts

This change still leaves out a lot. But at least it doesn't nudge folks
towards compiled_idl. Which was misleading some Tweeps, argh.

(I haven't been keeping track of Mondo-Merge status. If this change
gets lost after the merge and I have to re-do it, I promise not to cry.
I'm just that eager to get this particular set of lies out of our docs)

RB_ID=274373

(sapling split of 1802ba57bdc73bf8973d39d245696fc5a236e7f6)
[PATCH 09/27] Fix jvm_binary bundle error where executable jar does to contain classes generated from the binary source file.

RB_ID=253157

(sapling split of 9dc9a66597158592b7034aa7ed12ec2f2b6f56b2)
[PATCH 10/27] Append root_dir to pants path extension mechanism

RB_ID=277943

(sapling split of f7841f10c797dd45b14ee0921ea0477adc85335b)
[PATCH 11/27] Pants-thrift docs: the consume-side part of the publishing tangled tale

RB_ID=275069

(sapling split of 6e4c3c6b4ef9fb3e5277af565bb1a306396d12a0)
[PATCH 12/27] Fixup Config/BaseBuildRootTest to lazy-load and establish a minimal pants.ini respectively. Adapt tests that need a pants.ini to use BaseBuildRootTest and make the Extract Task work with defaults.

RB_ID=278957
TBR=true
NO-QUEUE=true

(sapling split of f650d5e472eeac1ea317fd52004874b1067b26ea)
[PATCH 13/27] Add TwitterStormBinary to pants

RB_ID=278663

(sapling split of 3e448265ba00e83389e365b866b5f34fd3fcc0d0)
[PATCH 15/27] add the --no-git-repo flag for thrift gemerator

RB_ID=280147

(sapling split of 918119711890c4babf4a261b48dd75a289656ea7)
[PATCH 18/27] Let's be clear: you can't just put on Pants. You need an expert tailor

RB_ID=283203

(sapling split of 253c5faf2fade7526d6449ad733995adccf15164)
[PATCH 19/27]  Initial checkin to move the replacement of keywords from remote_python_thrift_library to ThriftBuilder No Queueing this since submit queue timed out iron build #24 passed

RB_ID=279995
NO-QUEUE=true

(sapling split of f00fbebd7bd5ff2d6d9e520bfe6c15686d99da84)
[PATCH 20/27] pants-thrift docs: thrift idl artifacts, the publish part

RB_ID=283541

(sapling split of 9f8b5b436eaf5a40e6cf4410be45e4384a4d2e9a)
[PATCH 21/27] Alphabetize target dependencies This looks like a total yak shave, but it will make automating the moving of dependencies to 3rdparty/... easier.

RB_ID=285621
TBR=true

(sapling split of 3189674498304979ce21dbd2e5165593064f7984)
[PATCH 23/27] Update pants essentials with latest thrift stuff.

RB_ID=287519

(sapling split of b71636a99144aa5744c2d6abcde3238b1e98defd)
[PATCH 25/27] Fix dependees report to work through compiled_idl targets.

This change is related to the discarded https://rbcommons.com/s/twitter/r/15/
. Here we make the minimum change possible to resolve this issue. The full
solution is eliminating compiled_idl entirely, but as that will take a while
this change helps us avoid major CI breakage so we have time to work on stuff
like eliminating compiled_idl.

RB_ID=293425

(sapling split of c4bf65d97e9a7ce32fbdd27e3975a14ca107c469)
[PATCH 26/27] pants docs traveled: update references in science

RB_ID=292571

(sapling split of 92acf579e813b4d83df43f137aae806c1ed93948)
[PATCH 27/27] - Update to storm_binary pants macro so that it will work with storm v4.x and all prior versions of storm. - Storm 4.x uses jarjar to shade the majority of its dependencies so that they're hidden. Therefore we do not need to Exclude them anymore in pants, and actually excluding them can cause a build to break if for example someone needs guava they won't be able to take advantage of the shaded guava that is bundled on a storm cluster.

RB_ID=295961
TBR=true

(sapling split of 1eb12e4998ab9bbd7bf4af31bfc6fb85fed4cc85)
Kill Twitter internal storm_binary target and thrift_gemerator task.
Fixup bad merge of goal.py