commit 2- no errors in compiling but not working