made trade_controller test pass