Nice one. Sad you can still be bitten by over/underflow in 2014, but this
is how the language was designed...


On Wed, Mar 5, 2014 at 2:04 PM, David Turanski <notifications@github.com>wrote:

> In
> spring-xd-dirt/src/main/java/org/springframework/xd/dirt/container/initializer/CommonInitializer.java:
>
> > +package org.springframework.xd.dirt.container.initializer;
> > +
> > +import org.springframework.xd.dirt.util.ConfigLocations;
> > +
> > +
> > +/**
> > + *
> > + * @author David Turanski
> > + */
> > +public class CommonInitializer extends AbstractXMLBeanDefinitionProvider {
> > +
> > +	private static final String CONTEXT_CONFIG_ROOT = ConfigLocations.XD_CONFIG_ROOT + "initializers/common/";
> > +
> > +	@Override
> > +	public int getOrder() {
> > +		return Integer.MIN_VALUE - 1;
>
> I'm surprised that even compiles! Should be Integer.MIN_VALUE + 1 . Or in
> this case HIGHEST_PRECEDENCE is appropriate. I'm not sure
> HIGHEST_PRECEDENCE + 1 is that easy to understand though.
>
> --
> Reply to this email directly or view it on GitHub<https://github.com/spring-projects/spring-xd/pull/622/files#r10298197>
> .
>