[ticket/12990] Use the full services name for the notification's types

PHPBB3-12990
[ticket/12990] Fix unit tests

PHPBB3-12990
[ticket/12990] Use protected instead of private

PHPBB3-12990
[ticket/12996] Fix reliability issue in flock test.

$delta was always an int - so, this test would sometimes fail if you
happened to call time() /very/ close to a 1s boundary.

Found by HHVM's continuous testing.

PHPBB3-12996
Merge pull request #2892 from bantu/ticket/12996

[ticket/12996] Fix reliability issue in flock test.

* bantu/ticket/12996:
  [ticket/12996] Fix reliability issue in flock test.
[ticket/12989] Remove unused "created_by.jpg"

This image is not used anywhere in prosilver.

PHPBB3-12989
Merge pull request #2893 from bantu/ticket/12989

[ticket/12989] Remove unused "created_by.jpg"

* bantu/ticket/12989:
  [ticket/12989] Remove unused "created_by.jpg"
[ticket/12999] Remove @author tags

PHPBB3-12999
[ticket/12998] Fix use of $lang in mcp_warn.php

PHPBB3-12998
Merge pull request #2895 from Nicofuma/ticket/12998

[ticket/12998] Fix use of $lang in mcp_warn.php
[ticket/12994] Add core event to viewtopic.php before sending vars to template

Add core event to viewtopic.php before sending vars to template
to allow extensions performing additional actions/modifying data first.

PHPBB3-12994
Merge pull request #2889 from rxu/ticket/12994

[ticket/12994] Add core event to viewtopic.php before sending vars to template
Merge pull request #2885 from Nicofuma/ticket/12990

[ticket/12990] Use the full services name for the notification's types
Merge pull request #2894 from Nicofuma/ticket/12999

[ticket/12999] Remove @author tags

* Nicofuma/ticket/12999:
  [ticket/12999] Remove @author tags
[ticket/12990] Use {$var} instead of ${var}

PHPBB3-12990
[ticket/13003] Add missing language keys

PHPBB3-13003
[ticket/13004] Remove obsolete S_HAS_ATTACHMENTS check from topic tools.

PHPBB3-13004
Merge pull request #2898 from Nicofuma/ticket/12990

[ticket/12990] Use {$var} instead of ${var}
Merge pull request #2900 from prototech/ticket/13004

[ticket/13004] Remove obsolete S_HAS_ATTACHMENTS check from topic tools.

* prototech/ticket/13004:
  [ticket/13004] Remove obsolete S_HAS_ATTACHMENTS check from topic tools.
Merge pull request #2899 from Skouat/ticket/13003

[ticket/13003] Add missing language keys

* Skouat/ticket/13003:
  [ticket/13003] Add missing language keys