Fixing some of the scary bugs possible null pointer: created testSetNicDevIdIfCorrectVifIsNotNull

Signed-off-by: Hugo Trippaers <htrippaers@schubergphilis.com>
fixing FindBugs scariest for replaceFirst() method call that does not assign the return value

Signed-off-by: Hugo Trippaers <htrippaers@schubergphilis.com>
adding fix and unit tests for cloud-engine-api scariest

Signed-off-by: Hugo Trippaers <htrippaers@schubergphilis.com>
AJH Findbugs [9] - Added object to map rather than string

Signed-off-by: Hugo Trippaers <htrippaers@schubergphilis.com>
AJH Findbugs [8] - Added .toString() to enum.

Signed-off-by: Hugo Trippaers <htrippaers@schubergphilis.com>
Findbugs - Long equality fix.

Signed-off-by: Hugo Trippaers <htrippaers@schubergphilis.com>
Findbugs : Fix a number of potential NPEs and minor findings
Findbugs : A map can't retrieve an object by index, so get(0) would
return null. Changed to retrieve the first entry in the map.

Removed the ExecutionException try catch, this would prevent the
unittest from giving accurate information on exceptions. Avoid catching
checked exceptions in a unittest, use expected keyword on @Test instead.
Findbugs : Fixes for several findings

Made a comment on the use of ConcurrentHashMap for _agent
Conflicts:
	engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java
Findbugs : NP_NULL_PARAM_DEREF_NONVIRTUAL fixed
Findbugs : Fix several "of concern" findings.
Fix findbugs findings in cloud-plugin-network-ovs
OvsTunnelManagerImpl.java:456, RC_REF_COMPARISON, Priority: High

Serveral low priority fixes
Fix findbugs findings in cloudstack-service-console-proxy-rdpclient

Findings:
- 32 int shifted by an amount not in range -31..31:
	The shifts by 32 bits don't actually have any effect on the value
	(as shown by the tests)
- possible null pointer dereference
- repeated conditional test
- field only ever set to null
	All other uses of the field were to check if it was null,
	which it was, so it was removed

Other actions:
- Upgrade jUnit to version 4
- Add PowerMock dependency

Signed-off-by: Hugo Trippaers <htrippaers@schubergphilis.com>
Findbugs finding

Signed-off-by: Hugo Trippaers <htrippaers@schubergphilis.com>
findbugs findings

Signed-off-by: Hugo Trippaers <htrippaers@schubergphilis.com>
Fix findbugs findings in cloud-plugin-network-elb

    Findings:
    - comparing Longs by reference
    - possible null pointer dereference

Signed-off-by: Hugo Trippaers <htrippaers@schubergphilis.com>
Fix and test GroupBy SQL query creation

Signed-off-by: Ian Southam <isoutham@schubergphilis.com>
Signed-off-by: Hugo Trippaers <htrippaers@schubergphilis.com>
Fixes on Contrail and Mon InMemory plugins; adding comments about the changes.

Signed-off-by: Hugo Trippaers <htrippaers@schubergphilis.com>
error message containing array content instead of array
findbugs: check for system template id == -> equals()