fix NoMethodError on ShellOut calls

================================================================================
Error executing action `run` on resource 'execute[add repository]'
================================================================================

NoMethodError
-------------
undefined method `include?' for #<Mixlib::ShellOut:0x00000002c0b118>

Change-Id: Ib2f562e432373fe319eee1c8485cb112785b0f9b
Update spec_helper to include 'chefspec/berkshelf'

This minor change allows you to run rspec outside of strainer while
still having cookbook dependencies automatically handled by berkshelf
(which also means you can run individual chefspec tests).

Note that this change does marginally increase the time it takes to run
a strainer test.

A similar change was recently accepted in the openstack-compute
cookbook.

Change-Id: Ia5b5f3cc8aab853dd0e8c3b120ed178b0f0887db
Merge "fix NoMethodError on ShellOut calls"
Filling out initial rubocop support.

https://blueprints.launchpad.net/openstack-chef/+spec/lint-and-unit-testing-for-havana
Removing tailor, cleaning up metadata and Gemfile and adding TESTING.md

Change-Id: I193388f59f3265a6a549452fd798ee512f197603
Update the Gemfile to sync with latest Chef and ChefSpec.

Trying to keep all of the Gemfiles in sync so every cookbook has the same Gem
dependencies.

Change-Id: Ic8fd2bb285cae29b4589441eecf53c00d4232866
ensure sysctl.d exists (it does not by default on CentOS)

add a block to create /etc/sysctl.d, which is created by default
on ubuntu, but not centOS (though as of centOS 6.2, it is supported)

Change-Id: Id8011d7ef91cc13182f45adc201a3c66c8e891cd
Closes-Bug: #1266914
Implements: blueprint centos-rhel-for-common
Merge "Update the Gemfile to sync with latest Chef and ChefSpec."
first pass at adding havana repo for centOS/RHEL

Currently, the cookbooks attempt to install centOS/RHEL packages from
epel, since no other repo is configured.  epel contains folsom packages.

This commit drops in the official havana repo/gpg key so at least the
correct set of packages will attempt to be installed by chef.

Implements: blueprint centos-rhel-for-common

Change-Id: I76edc6538a71a8fb5f4242e8174aff9b3831834f
Merge "first pass at adding havana repo for centOS/RHEL"
Rubocop support for attributes.

Cleaned up double-quotes, spacing issues and added UTF-8 header.

Addresses: blueprint rubocop-for-common
Change-Id: I6693795072a684f21ff86bf4c75877f498af5b83
Rubocop support for recipes.

Added UTF-8 headers and cleaned up double-quotes. default recipe had several
unused variable assignments that were removed.

Change-Id: I12d41988020a5f4c4d53d38e7b203594697f8147
Move to use "get_password" instead of "{user,service,db}_password"

The user_password, service_password and db_password functions are redundant
since they simply call "secret". Creates a get_password function that
will accept a "type" of db, service or user.

All instances of these calls have been changed to call get_password.

Interim commit that keeps the service,db and user functions in order to
merge other changes.

Change-Id: Iba4a611b387d0975e8a23cc758d2ac7dec8210ad
Partial-Bug: #1195915
Add charset=utf8 to DB2 URI

Change-Id: I4535290d2e69c966dc65eb340cd0ba17af9883e6
Merge "Rubocop support for recipes."
Remove user_password, db_password and service_password

All cookbooks are using "get_password" now, so removing the redundant
functions as a "clean-up"

Fixes bug: #1195915

Change-Id: I2c651fdf43935263ea60bc48fa7785dd006c2940
Remove Berksfile.lock from dev branches

blueprint remove-berksfile-lock-from-dev-branches

Change-Id: I4d9643b7739446943d648a7e9a6d4bb6e9ad0c63
Initial step to clean up db and mq attributes

Here we move db and mq attributes already present in default.rb
attributes into new files (database.rb,messaging.rb).  Additionally, we
pull in rabbit/mq attributes from
openstack-{block-storage,compute,image,metering,network} while
transforming namespace from openstack.SERVICE.mq and
openstack.SERVICE.rabbit to openstack.mq.SERVICE
and openstack.mq.SERVICE.rabbit.  Lastly, we copy
openstack.SERVICE.db.username attribute from
openstack-{compute,dashboard,identity,image,metering,network} while
transforming namespace to openstack.db.SERVICE.username.

Change-Id: I50c900aa2ba92ce53f4a6ad05aeabd59e701b514
Implements: blueprint clean-up-attr-for-mq-and-db
Update spec files to be rubocop compliant

- Move to use a single .rubocop.yml file
- Adjust Strainerfile to use single .rubocop.yml file
- Ensure all spec files are rubocop compliant

Addresses: blueprint rubocop-for-common
Change-Id: I550c50c55edd4725782385de2c0f66bedff3004e
Update libraries to be rubocop compliant

- Update .rubocop.yml to include libraries/**
- Update libraries to be rubocop compliant
- Update recipes/default.rb to remove unrequired rubocop:disable

Addresses: blueprint rubocop-for-common
Change-Id: I12a86bec70d1b9127d3b7d52356441637253e4f1
Merge "Remove Berksfile.lock from dev branches"