Yep, it definitely was. It was supposed to ensure that the inputOrder was 0 or greater (the 1 in the if is wrong, the 0 in the error message was right).

From: Matthew Amato [mailto:notifications@github.com]
Sent: Thursday, May 29, 2014 5:37 PM
To: AnalyticalGraphicsInc/cesium
Cc: Dunkel, Michael
Subject: Re: [cesium] Interpolation using derivative info in HermitePolynomialApproximation (#1758)


In Source/Core/HermitePolynomialApproximation.js:

> -    HermitePolynomialApproximation.getRequiredDataPoints = function(degree) {

> -        return Math.max(degree + 1, 2);

> +

> +    HermitePolynomialApproximation.getRequiredDataPoints = function(degree, inputOrder) {

> +

> +        inputOrder = defaultValue(inputOrder, 0);

> +

> +        //>>includeStart('debug', pragmas.debug);

> +        if (!defined(degree)) {

> +            throw new DeveloperError('degree is required');

> +        }

> +        if (degree < 1) {

> +            throw new DeveloperError('degree must be 1 or greater');

> +        }

> +        if (degree < 1) {

> +            throw new DeveloperError('degree must be 0 or greater');

You have the same degree check twice, I assume one of these is supposed to be inputOrder?

—
Reply to this email directly or view it on GitHub<https://github.com/AnalyticalGraphicsInc/cesium/pull/1758/files#r13206308>.