edit function finished
committing