Improve the extra routes test on router

Insure that the values returned by the
update_extra_routes method are correct and that
the show_router method returns the extra route
information.

Change-Id: I62891ebc522b1aa9689d9b4c0c8f88d9b4910c8b
Check for 'Generated' in SSH key comment

This test fails for https://review.openstack.org/76904 (replace spaces with
dashes in Nova generated SSH key comments) and thus prevents 76904 from
merging. This change simply checks for 'Generated' in the SSH key comment
instead of 'Generated by' which contains a problematic space.

Related-Bug: #1297685
Change-Id: I3adf4e8fa4de3bd7ad7773b345d80e671442ade6
Removing unnecessary pass instructions

There are some files in Tempest where code has unnecessary
pass instructions. This CR fixes that.

Change-Id: Ie32399d731edad8a4d0b9cdec8aa7e9444eda254
Enforces the use of Credentials (part2)

Multiversion auth part5

Refactor mangers, utils and test base classes to use Credentials instead
of username, password and tenant_name.
Makes changes to tests where needed - some of the tests create their own
managers.

Partially implements: bp multi-keystone-api-version-tests

Change-Id: If05f5704d90390362cebf45e2664f2bfbc72268d
Add unit tests for tempest hacking checks

This commit adds unit tests for the remaining untested hacking checks:
 - T102: import_no_clients_in_api
 - T104: scenario_tests_need_service_tags
 - T106: no_vi_headers
 - T107: service_tags_not_in_module_path

Change-Id: Ib2a82c5e92fbd7f165477f1906cf117f064fcef5
Verify update host Nova V2/V3 APIs attributes

This patch adds the JSON schema for Nova V2 & V3 update host
APIs response and validate the response with added
JSON schema to block the backward incompatibility change in the future.

The response body of update host V2 API is below:

{
    "host": "%(host_name)s",
    "maintenance_mode": "off_maintenance",
    "status": "enabled"
}

The response body of update host V3 API is below:
{
    "host": {
        "host": "%(host_name)s",
        "maintenance_mode": "off_maintenance",
        "status": "enabled"
    }
}

Partially implements blueprint nova-api-attribute-test

Change-Id: Idecedd2bbe98444b07dcf328bc73ca84e68a197a
Verify the response attributes of 'create-aggregate' API

This patch verifies the response attributes of 'create-aggregate'.
The response attributes of v2 and v3 are the same:
{
    "aggregate": {
        "availability_zone": "nova",
        "created_at": "2012-10-01T18:50:27.781065",
        "deleted": false,
        "deleted_at": null,
        "id": 1,
        "name": "name",
        "updated_at": null
    }
}
The status_code is different:
  v2 -> 200
  v3 -> 201
This patch also fixed a typo bug in the compute/aggregates.py

Partially implements blueprint nova-api-attribute-test

Change-Id: I584ee2b9ac6033fb365a8dadd4e3844b1c37edb2
refactor out code duplication

pull out the duplication of setup that was in all the test
functions and put it in setup instead.

capture stdout/stderr on pretty tox tests

if something goes wrong in the pretty tox tests, we actually get
entirely unhelpful 1 != 0 errors, that provide no ability to
debug. A big part of this is because stdout and stderr were not
captured.

Capture and replay stdout / stderr in case of fails to be able to
debug.

Change-Id: I7c21e47805a765d9e3c8f367dfa153d54ff10414
Merge "Check for 'Generated' in SSH key comment"
Merge "Improve the extra routes test on router"
Merge "Enforces the use of Credentials (part2)"
Merge "Add unit tests for tempest hacking checks"
Merge "Verify update host Nova V2/V3 APIs attributes"
Merge "Verify the response attributes of 'create-aggregate' API"
Merge "Removing unnecessary pass instructions"
Merge "refactor out code duplication"
Merge branch 'master' of https://github.com/openstack/tempest