On 02/18/2014 07:24 PM, Yiqiao Pu wrote:
>
> In qemu/control_files/control.kernel-version:
>
> > @@ -106,7 +112,7 @@ def package_check(dict_test, verbose=False):
> >
> >      return True
> >
> > -qemu_test_dir = os.path.join(os.environ['AUTODIR'],'tests/virt/qemu')
> > +qemu_test_dir = os.getcwd()
>
> Should we use functions from data_dir to get this value?
>
We have three way to get this value.

1. os.getcwd().  It is not a good way. We have to run test under qemu 
folder.

2. get it by data_dir with long terms.

3. get it according to control.kernel-version file  location.



I perfer to 3. As control.kernel-version is in tp-qemu,  It will not 
change the location in recent days.  At least we did not update two repo 
when changing it.


For 2: We have split code into two sub repos. Why still set two repo in 
a fixed folder structure? 
"virt/test-providers.d/downloads/io-github-autotest-qemu/qemu/"





> —
> Reply to this email directly or view it on GitHub 
> <https://github.com/autotest/tp-qemu/pull/24/files#r9819825>.
>