:D That’s exactly what I meant! .tab stays.

--  
Mihnea Dobrescu-Balaur

------------------------------------------------------
From: Andrei Oprea notifications@github.com
Reply: uberVU/elasticboard reply@reply.github.com
Date: 30 Mar 2014 at 11:25:53
To: uberVU/elasticboard elasticboard@noreply.github.com
Cc: Mihnea Dobrescu-Balaur mihneadb@gmail.com
Subject:  Re: [elasticboard] Js sweep (#112)

> > return;
> > }
> > + checkForRepo(user, repo, function(res) {
> > + if (res) {
> > +
> > + App.REPO = user + '/' + repo;
> > + App.BASE = App.HOST + '/' + App.REPO;
> > +
> > + $('#user-repo').text(App.REPO);
> > +
> > + if (!App.Components.graph) {
> > + drawGraphs();
> > + App.Components.graph = true;
> > + }
> > + $('.tab').hide();
> > + $('#tab-2').show();
>  
> Having all of them named `.tab` I can hide them in just one line of JS no
> mater how many tabs there actually are.
> We could change the #id to be `#tab-graphs` etc.
> What do you think ?
>  
>  
> On Sun, Mar 30, 2014 at 11:57 AM, Mihnea Dobrescu-Balaur <
> notifications@github.com> wrote:
>  
> > In dashboard/js/app.js:
> >
> > > return;
> > > }
> > > + checkForRepo(user, repo, function(res) {
> > > + if (res) {
> > > +
> > > + App.REPO = user + '/' + repo;
> > > + App.BASE = App.HOST + '/' + App.REPO;
> > > +
> > > + $('#user-repo').text(App.REPO);
> > > +
> > > + if (!App.Components.graph) {
> > > + drawGraphs();
> > > + App.Components.graph = true;
> > > + }
> > > + $('.tab').hide();
> > > + $('#tab-2').show();
> >
> > Maybe we should call these tab-timeline, tab-insights and tab-graphs?
> >
> > --
> > Reply to this email directly or view it on GitHub  
> > .
> >
>  
>  
>  
> --
> Andrei Oprea
>  
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/uberVU/elasticboard/pull/112/files#r11097364