Implement unauthenticated logic for /v2/service_plans and /v2/services

This commit was initially reverted as part of the attempt to reduce CC
flakes. We've cherry-picked this commit back in and run the tests.
Everything looks fine, so we're putting the commit back in.
Added service guid in service plans response for unauthenticated users

- added visibility filter for unauthenticated access
- serivce guid no longer filtered out for unauth users
- added tests that verify that unauth users can list the services and
  public service plans

[#70028330]
diego staging completion handler handles failure
Change 3 polluting tests to non-transactional
Pollution Detection option added to specs

DETECT_POLLUTING_SPECS=true enables comparison of row count
for each table before and after each spec to detect pollution

[#72144466]
Wrap a describe block around a test case that did not have one
appease RuboCop: AssignmentInCondition
Run specs without parallel_test on travis

* Also include the DETECT_POLLUTING_SPECS flag

[#71948064]

Signed-off-by: James Myers <jmyers@pivotallabs.com>
Correct api doc for positioning buidpacks

Added the required buildpack guid to the resource name and removed stale
comment about 'position 0` buildpacks.

[#71328862]
Update API Docs checksum

Signed-off-by: Joseph Palermo <jpalermo@pivotallabs.com>
Remove non_transactional flag from UsageEvent repo specs

* We stubbed truncate with dataset.destroy for test only. It should have the
  same behavior, but will not autocommit the transaction in mysql.
* Removing the non_transactional flag will greatly increase the speed of each
  spec affected

[#71446796]

Signed-off-by: James Myers <jmyers@pivotallabs.com>
Reseed stacks when resetting the database in test

[#71446796]

Signed-off-by: James Myers <jmyers@pivotallabs.com>
Remove non_transactional flag from service broker specs

* It appears as if only one spec, "does not delete the broker", depended on
  the non_transactional behavior.

[#71446796]

Signed-off-by: Michael Fraenkel <fraenkel@us.ibm.com>
V2 broker bindings should store syslog_drain_url

When a V2 service broker is bound and the binding returns a syslog_drain, use the provided value.
Typo

Failed to close if statement
Add test for syslog_drain_url bind
Merge branch 'master' of github.com:trastle/cloud_controller_ng