adding params and upload