I agree. I'll make the change when I wake up tomorrow.

Sincerely,
Mathew Lenning

Babel-university.com

P.S. This message was sent via iPhone, so please forgive any errors

> On Apr 26, 2014, at 12:34 AM, George Wilson <notifications@github.com> wrote:
> 
> In libraries/cms/controller/add.php:
> 
> > +	 */
> > +	public function execute()
> > +	{
> > +		$config = $this->config;
> > +		$prefix = $this->getPrefix();
> > +		$model = $this->getModel($prefix, $config['subject'], $config);
> > +
> > +		if (!$model->allowAction('core.create'))
> > +		{
> > +			$msg = $this->translate('JLIB_APPLICATION_ERROR_CREATE_RECORD_NOT_PERMITTED');
> > +			$url = 'index.php?option='.$config['option'].'&task=display.'.$config['subject'];
> > +			$this->setRedirect($url, $msg, 'error');
> > +			return false;
> > +		}
> > +
> > +		parent::execute();
> I'd much rather see us return parent::execute in situations like this - because that can return false or true as well
> 
> \
> Reply to this email directly or view it on GitHub.