run_buffer(): unblock all signals for spawned scripts.

Currently, all scripts, specified as "lxc.network.script.up", inherit
lxc-execute's signal mask.
This, for example, includes blocked SIGALRM signal which, in turn, makes
alarm(2), sleep(3) and setitimer(2) functions silently unusable in all programs,
invoked in turn by the "lxc.network.script.up".
To fix this, run_buffer() should restore default signal mask prior to
executing "lxc.network.script.up".

A naive implementation would temprorary unblock all signals just before
calling popen() and block them back immediately after it.
But that would result in an immediate delivery of all pending signals just
after their unblocking.
Thus, we should restore default signal mask exactly in child (after fork())
just before calling exec().
To achieve this, a home-brewed popen() alternative is needed.
The added lxc_popen() and lxc_pclose() are mostly taken from glibc with
several simplifications (as we currently need only "re" mode).
The implementation uses Linux-specific pipe2() system-call,
which is only available since Linux 2.6.27 and supported by glibc since
version 2.9 (according to pipe(2) man-page), but this shouldn't be a
problem as lxc requires a fairly recent kernel too.

lxc_popen()/lxc_pclose() are meant to be direct replacements for their
stdio counterparts, so they perform no process_lock() locking
themselves. (as fopen_cloexec() does)
All existing users of popen()/pclose() are converted to the new
lxc_popen()/lxc_pclose().

(mazo: don't clear close-on-exec flag for parent's end;
place the new functions in utils.c;
convert bdev.c to use the new functions;
coding style fixes;
comments fixes;
commit message tweaks)

Signed-off-by: Ivan Bolsunov <bolsunov@telum.ru>
Signed-off-by: Andrey Mazo <mazo@telum.ru>
lxc-test-concurrent: initialize saveptr before use

Signed-off-by: Qiang Huang <h.huangqiang@huawei.com>
Acked-by: Stéphane Graber <stgraber@ubuntu.com>
Make public API string method parameters const where possible.

Signed-off-by: James Hunt <james.hunt@ubuntu.com>
Acked-by: Stéphane Graber <stgraber@ubuntu.com>
ubuntu: Make vim part of base template

This moves vim back to the default list of packages, drops the duplicate
ssh entry which means that unless extra packages are passed through
--packages, container creation won't invoke apt-get anymore.

Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>
Acked-by: Serge E. Hallyn <serge.hallyn@ubuntu.com>
plamo: Update because rc script of plamo was updated

Signed-off-by: TAMUKI Shoichi <tamuki@linet.gr.jp>
Signed-off-by: KATOH Yasufumi <karma@jazz.email.ne.jp>
Acked-by: Stéphane Graber <stgraber@ubuntu.com>
lxc-ls: Detect missing setns support

Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>
Acked-by: Serge E. Hallyn <serge.hallyn@ubuntu.com>
Fix uninitialized value in lxc_try_cmd

Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>
initialize stopped at top of lxc_cmd

and don't do it at all the callers

Signed-off-by: Serge Hallyn <serge.hallyn@ubuntu.com>
python3: Support unpriv containers

This removes any existing uid check in the python3 binding and tools,
replacing those by .controllable where appropriate.

Extra checks are also added to make lxc-ls work as a user, returning as
much information as can possibly be retrieved.

Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>
Acked-by: Serge E. Hallyn <serge.hallyn@ubuntu.com>
typo fix: create $rootfs/dev/pts

Signed-off-by: Serge Hallyn <serge.hallyn@ubuntu.com>
don't run lxc-user-nic for empty netns

Signed-off-by: Serge Hallyn <serge.hallyn@ubuntu.com>
coverity : fix memleak on error path

Signed-off-by: Serge Hallyn <serge.hallyn@ubuntu.com>
coverity: fix memleak in userns_exec_1

Signed-off-by: Serge Hallyn <serge.hallyn@ubuntu.com>
coverity: change flow to safely free in all exit paths

Signed-off-by: Serge Hallyn <serge.hallyn@ubuntu.com>
coverity: fix use before null check

Signed-off-by: Serge Hallyn <serge.hallyn@ubuntu.com>
coverity: avoid deref of explicitly NULL variable on error path

Signed-off-by: Serge Hallyn <serge.hallyn@ubuntu.com>
coverity: fix mix of bool and int

Signed-off-by: Serge Hallyn <serge.hallyn@ubuntu.com>
coverity: an int is not 1 byte

Signed-off-by: Serge Hallyn <serge.hallyn@ubuntu.com>
coverity: don't deref null c

Signed-off-by: Serge Hallyn <serge.hallyn@ubuntu.com>
coverity: drop gratuitous null check

Signed-off-by: Serge Hallyn <serge.hallyn@ubuntu.com>