! akka-cluster: metrics collector improvements - resolve #16121

oh,  you mean "all places"! :-) sure

-------- Original Message --------
Subject: Re: [akka] ! akka-cluster: metrics collector improvements -
resolve Patrik Nordwall6121 (#16354)
From: Patrik Nordwall <notifications@github.com>
To: akka/akka <akka@noreply.github.com>
Cc: Andrei Pozolotin <Andrei.Pozolotin@carrotgarden.com>
Date: Fri 21 Nov 2014 09:52:30 AM CST
>
> In akka-cluster/src/main/scala/akka/cluster/ClusterMetricsCollector.scala:
>
> >  
> >    private def this(cluster: Cluster) =
> >      this(cluster.selfAddress,
> >        EWMA.alpha(cluster.settings.MetricsMovingAverageHalfLife, cluster.settings.MetricsInterval),
> > -      cluster.system.dynamicAccess.createInstanceFor[AnyRef]("org.hyperic.sigar.Sigar", Nil).get)
> > +      new Sigar())
> > +
> > +  /**
> > +   * Verify during construction that Sigar is operational.
> > +   */
> > +  metrics
>
> strange, can't you change it to |metrics()| in all places?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/akka/akka/pull/16354/files#r20722174>.
>