opr: Silence rbtree warning

On OS X, gcc can complain that 'child' is uninitialized whenever this
'else if' condition is false. We already handled the case where both
node->right and node->left are non-NULL earlier in this function, so
this should never occur. So, to get rid of the warning, just always
take the path in the 'else if', and assert that the right child is
NULL.

Change-Id: I3575de84ea172d3c7e0e022809fdcd0e3b4dcc27
rfc3961: Use enctypes, not keytypes

We previously defined the enctype symbols to be aliases for keytype
symbols.  The numerical values matched what we wanted (since these
values are specified in an IANA registry), but the C type is not
required to be the same for enctypes and keytypes.

Some of our buildslave configurations notice the type mismatch and
complain, so fix the types by using the enctype enum for enctype symbols
instead of keytypes.

Change-Id: I56ca634d52954ee44baa34e2d8c876271f171288
afs_fetchstore: avoid use of uninitialized variable

rxfs_fetchInit() attempts to do a 64-bit RPC first, but falls back
to the 32-bit StartRXAFS_FetchData() if the server appears to not
support the 64-bit RPCs.

We correctly did not read a length from the call if the FetchData
RPC(s) failed, but proceeded to assign from the 'length' local
variable into the 'alength' output variable unconditionally later on.

Instead of blindly continuing on, jump to the error-handling part of
the routine when we cannot read a length from the call.  This has the
side effect of skipping an afs_Trace3() point in the error case.

Change-Id: I4840d5c692c61630c68e97b5e88f9460abade19e
Add a routine to get the size of the current process

Use rusage when available, and fall back to the very old sbrk(0)
hack otherwise.

Change-Id: Ic986fd6b93476b80008908a95f8b8e0c76d9ed9a
Remove some explicit sbrk() usage

Mac OS X 10.9 now considers this function deprecated and warns on
its use, causing the buildslave configuration to error out.

Use the library routine to get a process's size instead of inlining
the call to sbrk (which is unlikely to have worked as intended for
quite some time -- most malloc implementations in use do not use
sbrk to get their storage).

Change-Id: If616e1ebbea7c0aa541fb96c486820e883363df1
viced/callback.c: Ignore dump write errors even harder

Not only do we need to check the return value of write(2), but
we also need to do so in a way that does not leave an empty body
in the if statement, in order to appease the clang-500.2.79 found
on OS X 10.9 with Xcode 5.0.2.

Change-Id: I4564f05927fe14fea3365e9e250834ee948fe387
vol/salvaged.c: Remove unused variable

It was incremented from an uninitialized value, which caused a build
error on the OS X 10.9 buildslave.  Since it's unused, just remove
it entirely.

Change-Id: I845e9139ffd27ba7bf4e010cf4e5625658125486
Disable deprecated warnings for krb5 routines

In OS X 10.9 Mavericks, Apple has marked all of the krb5 routines
as deprecated (in favor of the GSS framework).  We must disable
these warnings in order to allow the buildslave to have a successful
build.

Add the appropriate pragmas where krb5 routines are used, and document
them in README.WARNINGS.

Change-Id: Iedc920001fdc5731254336424b0ab7b27274555c
Add braces to avoid a 'dangling else' warning

Change-Id: I301d7d2473d651002f0bf6baa18906bce6d46497
Use an explicit symbol for unknown vnode types

Avoid trying to get clever with stuffing -1 into an unsigned bitfield,
which causes the value to change and generates a warning from clang.

Change-Id: I5662887e5a68c7e687025d19226f821d8f2d6a09