Corrections after refactoring window-managing code

* slime-tests.el (narrowing): Use `quit-window'.

* slime.el (slime-with-popup-buffer): Restore `mode' keyword arg,
defaults to `fundamental-mode'. Compute package and connection in
calling buffer.
(slime-with-popup-buffer): Bind q to `quit-window'
(slime-popup-buffer-quit): Remove it.
(slime-show-compilation-log, slime-edit-value-callback)
(slime-show-apropos, slime-with-xref-buffer)
(slime-create-macroexpansion-buffer, slime-list-threads)
(slime-list-connections, slime-inspector-buffer): Restore mode
arg.
(slime-goto-note-in-compilation-log): Fix search and recenter
(slime-edit-value-commit, slime-goto-xref, sldb-exit)
(sldb-close-step-buffer, slime-quit-threads-buffer)
(slime-inspector-quit): Use `quit-window'
(slime-show-source-location): Fix it.
(sldb-show-frame-details): Fix it (sldb-recenter-region was gone).
(slime-list-threads): Don't `local-set-key'.
(slime-thread-control-mode-map): Bind `q' here.
(slime-inspector-mode): Restore docstring.

* contrib/slime-clipboard.el (slime-clipboard-display-entries): idem

* contrib/slime-compiler-notes-tree.el (slime-list-compiler-notes): idem

* contrib/slime-sprof.el (slime-sprof-report): idem

* contrib/slime-trace-dialog.el (slime-trace-dialog--open-detail): Restore
`:mode' argument to `slime-with-popup-buffer'.