make private classes private, dont pass params
Merge pull request #107 from jlambert121/private_classes

make private classes private, dont pass params
Fix dependency issues between repo configuration and package installation
(makes sure repo configuration is finished before installing packages).
Classes containing other classes need to use the anchor pattern to ensure this
(see http://docs.puppetlabs.com/puppet/2.7/reference/lang_containment.html
and http://projects.puppetlabs.com/issues/8040 for details).
Fix grep bug when plugin version specified

 * The jenkins::plugin fact is a comma separated string of plugins. When
   a plugin version is specified, the string to search is:
   'myplugin 1.2.3,'

   However, the last plugin in the jenkins::plugin fact doesn't end with
   a comma. This results in that plugin not being found by grep() and so
   puppet tries to install the plugin on each run.

   Adding a simple regex alternation checking for comma or end-of-string
   (,|$) fixes this.

 * Added test cases.
Merge pull request #109 from mark0n/master

Fix dependency issues between repo setup and package installation
Merge pull request #111 from butlern/fix_plugin_grep_bug

Fix grep bug when plugin version specified
Update to v1.0.1 for some minor fixes
Mock out the `stdlib` class in all cases for RSpec

This fixes a test regression introduced in #109. I believe there is an
underlying issue here where rspec-puppet is not properly loading or respecting
the spec/fixtures/modules directly.

Committing from 37,000ft, no bandwidth to investigate further :(
Refactor some RSpec Facter test helpers into spec_helper.rb

This fixes a minor test regression introduced in #111, wherein Facts defined in
some rspec-puppet were not getting flushed before running the RSpec unit tests
Merge tag 'v1.0.1' into next

Conflicts:
	Modulefile
	manifests/repo/debian.pp
	spec/classes/jenkins_repo_debian_spec.rb
	spec/classes/jenkins_spec.rb
Fix some additional "could not find class stdlib" errors in RSpec examples

Failures:

  1) jenkins plugins default
     Failure/Error: it { should contain_class('jenkins::plugins') }
     Puppet::Error:
       Could not find class stdlib for kiwi on node kiwi
     # ./spec/classes/jenkins_plugins_spec.rb:8:in `block (4 levels) in <top (required)>'

Finished in 1.3 seconds
4 examples, 1 failure

Failed examples:

rspec ./spec/classes/jenkins_plugins_spec.rb:8 # jenkins plugins default
Add a real update-center.json to spec/fixtures for testing a provider
Having debugger and debugger-pry running around might be useful
Refactor the pre_condition hacks into an RSpec shared context.

DRY!
Move the fact specs into a more specific dir

This should prevent too much clutter for devs trying to find tests
Refactoring code into more modular Ruby code to pave way for reuse

Provider and type code will have some overlap with the Facter code
Adding a package provider stub for a :jenkinsplugin provider
Refactor the $jenkins_plugins fact more, the fact will now be alphabetically sorted and more consistent

This also opens up the ability to use Puppet::Jenkins::Plugins#available inside
the plugins package provider (to be written)