Hi Adam,
All comments are addressed and the pull request is refreshed with two more changes. Please let us know if anything is needed.
Thanks!

Best Regards,
Xin Yao

----- Original Message -----
From: "Adam Stegman ⚛" <notifications@github.com>
To: "cloudfoundry/bosh" <bosh@noreply.github.com>
Cc: "Xin Yao" <xyao@vmware.com>
Sent: Thursday, May 29, 2014 1:36:52 PM
Subject: Re: [bosh] Enable SRM on vsphere by replacing the workflow of reading settings from cdrom with reading from attached independent disk (#581)



In bosh_agent/spec/unit/infrastructure/vsphere/settings_spec.rb: >  
> -    FileUtils.mkdir_p(cdrom_dir)
> -    File.open(env, 'w') { |f| f.write(settings_json) }
> +    it "should fail when there is no cdrom" do
> +      settings.stub(:read_cdrom_byte).and_raise(Errno::ENOMEDIUM)
> +      lambda {
> +        File.should_receive(:read).with('/proc/sys/dev/cdrom/info').and_return(@proc_contents)
> +        settings.send(:check_cdrom) 

You switched this method from public to private. I'm suggesting that you test via the public interface rather than doing private-method-specific tests. 

— 
Reply to this email directly or view it on GitHub