Changed

 

Although, with regards to (int), (string) etc casting and also $t_* and $c_, we are not as consistent in our handling as we could be – from elsewhere in the code:

 

$c_email = $t_email;

$c_username = $f_username;

$c_realname = $t_realname;

 

In the above case, all 3 have been checked, all 3 started from the same place (a form field), but it’s not immediately clear from the above that  this is actually the case.

 

 

 

 

From: Victor Boctor [mailto:notifications@github.com] 
Sent: 05 April 2014 06:44
To: mantisbt/mantisbt
Cc: grangeway
Subject: Re: [mantisbt] Mantis 2.0 - Database Layer Patch (#156)

 

In core/user_api.php:

> @@ -647,13 +611,11 @@ function user_delete( $p_user_id ) {
>       # Remove project specific access levels
>       user_delete_project_specific_access_levels( $p_user_id );
>  
> -     $t_user_table = db_get_table( 'user' );
> -
>       # unset non-unique realname flags if necessary
>       if( config_get( 'differentiate_duplicates' ) ) {
>              $c_realname = user_get_field( $p_user_id, 'realname' );

$t_realname?

—
Reply to this email directly or view it on GitHub <https://github.com/mantisbt/mantisbt/pull/156/files#r11320188> .