modals working now