Minor cleanup

- remove unused variable
- fixed indentation
- Get the floating network's VLAN id from the correct value of the network
  attribute. It doesn't make a real difference as the public and floating VLANs
  need to be the same currently. But this is cleaner.
Re-arranged generation of provider network options

There should be no difference between provider networks generated for
linuxbridge or openvswitch setups, when using the "VLAN" networking modes.

Previously we didn't add any --provider options in openvswitch based setups.
Which cause the segmentation_id attribute to be auto-populated with a wrong
value.
Honor the :use_vlan flag when creating the floating network

If use_vlan is false for the floating network we need to create the floating
network with type "flat". Otherwise it will endup being tagged to a VLAN and be
inaccessible from the public network (especially when using linuxbridges).
Merge pull request #91 from rhafer/floating_no_vlan

Fix creation of floating network when vlan is disabled.
ha: Make neutron-ha-tool start after haproxy and neutron-server

Otherwise, neutron-ha-tool fails to start.

Of course, we only do that when neutron-server and neutron-l3 roles are
on the same cluster, and both with HA.
Merge pull request #96 from vuntz/order-constraints

ha: Make neutron-ha-tool start after haproxy and neutron-server
Handle multiple DNS forwarders correctly

Oslo.config expects list optionts to be separated by
comma, not space (see
http://docs.openstack.org/developer/oslo.config/types.html)

(cherry picked from commit ef4b976faaf3a95797356ae2e8527d0c94f9a4fe)