partition should be in the functions not files
update comment