Cleanup of Partition and its uses

- Removed factset id and base dir from Partition
- Cleaned up globbing

There are things in here which will be removed once the plan work has finished
It is really tangled up (it was before as well). We have one case off parameterizing by a function to customize behaviour, and one case of returning a bool. If it isn't too hard, it would be nice to just fix this, otherwise raise a card and can you quickly look at it as soon as this one is merged.