Add test suite for verifying Lua global variables/tables of previous releases have not disappeared.

Several bugs have been introduced due to changing of perl scripts or #define names, such
that things exported into Lua have dissapeared or changed unintentionally. This commit
adds a test suite which compares the Lua global table with the ones from previous
releases (1.8 and 1.10), to verify nothing has gone missing. New items can be added, but
old ones cannot go away. The added script to verify these things, called 'verify_globals.lua',
also has the ability to display what's new - i.e., what was not in the olrder releases.

Lastly, this commit also fixes a bug: MENU_STAT_ENDPOINT became MENU_STAT_ENDPOINT_LIST
due to a change in the make-init-lua.pl perl script in this 1.11 release.

Change-Id: Iba143d1a436e706970635a5f8cc2b317955392bf
Reviewed-on: https://code.wireshark.org/review/284
Reviewed-by: Evan Huus <eapache@gmail.com>
Tested-by: Evan Huus <eapache@gmail.com>
Fix Dead Store (Dead assignement/Dead increment) warning found by Clang

Change-Id: I329fd1cec092e425dd0f6c2c1992d278dcdba743
Reviewed-on: https://code.wireshark.org/review/293
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
EPL + openSAFETY: Better handling of guint in EPL

 This is a permanent solution for bug #9786. guint overflows
 are now prevented, and the remaining length is queried from
 tvb and taken into consideration.

 As a side-effect, the fix brought up two bugs in the openSAFETY
 dissector, which where fixed as well.

 Upd: Remove stdio.h and fix one encoding error found by
 fix-encoding-args.pl

Change-Id: Ic2d478a8ea15b0bcfd2536a074c217daf610fe08
Reviewed-on: https://code.wireshark.org/review/291
Reviewed-by: Roland Knall <rknall@gmail.com>
Reviewed-by: Evan Huus <eapache@gmail.com>
Moving custer list/cluster id attribut to items

Change-Id: If23c530b10c67613311aa8a8a1b1a8acf95f3c48
Reviewed-on: https://code.wireshark.org/review/294
Reviewed-by: Evan Huus <eapache@gmail.com>
Fix Dead Store (Dead assignement/Dead increment) warning found by Clang

Change-Id: Ic3a240a2e751700f653287dd84fe58016adab9e2
Reviewed-on: https://code.wireshark.org/review/297
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Fix Dead Store (Dead assignement/Dead increment) warning found by Clang

Change-Id: I05ca21d94bbaa8c92a33f02ceb100c206c198052
Reviewed-on: https://code.wireshark.org/review/298
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Fix bug 9790: Lua: wslua allows duplicate field registration

As discussed in bug 3513 and 9709, one can register more than one new ProtoFields for
the same field name. Of course C-code can do that too, and does a LOT apparently, but
if they're not similar ftypes then things can get scrweed up in display filters.

So this change prevents duplicate field registration of dissimilar ftypes. The
similarity is based on the discussion on the mailing list, and the listing in
README.developer has been updated to refelect that as well.

Also, this change adds a testscript for Proto/ProtoFields.

Change-Id: I43bd323f785245941a21289647332a19adec2a9d
Reviewed-on: https://code.wireshark.org/review/285
Reviewed-by: Evan Huus <eapache@gmail.com>
Update the "latest version" URL in manuf/manuf.tmpl.

Regenerate manuf. I *really* wish Gitweb URLs were less ugly.

Change-Id: I51eabe1a028999859499466a9369106f465dec80
Reviewed-on: https://code.wireshark.org/review/300
Reviewed-by: Gerald Combs <gerald@wireshark.org>
Cleanup the automatically-generated fields to match the rest.

Change-Id: I217d5c390c806dfa28c7e9ff155ef927ed2a9111
Reviewed-on: https://code.wireshark.org/review/303
Reviewed-by: Guy Harris <guy@alum.mit.edu>
Add bug 9492.

Change-Id: I412d5c56848f2a19c8bf2c2e50f1ad1db86ce793
Reviewed-on: https://code.wireshark.org/review/306
Reviewed-by: Guy Harris <guy@alum.mit.edu>
TVB API deprecations and cleanup

- rename tvb_length and similar to tvb_captured_length and similar; leave
  #defines in place for backwards-compat, but mark them clearly as deprecated in
  code comments and in checkAPI
- remove tvb_get_string as C code and just leave a #define in place for
  backwards-compat; mark it clearly as deprecated in code comment and checkAPI
- update READMEs and sample dissector for all of the above
- while in the neighbourhood, make checkAPI skip (and warn) for missing files
  instead of bailing on the whole check, so subsequent files still get checked

Change-Id: I32fc437896ca86ca73e9b49d5f50400adf8ec5ad
Reviewed-on: https://code.wireshark.org/review/311
Reviewed-by: Evan Huus <eapache@gmail.com>
Fix clang warning regarding null pointer use in packet-sip.c.

In malformed sip-sec header fields, missing spi-c/spi-s values will
cause thie 'value' pointer to remain NULL, leading to bad things.
This fix checks for that and adds an expert warning about malformed
sip-sec mechanism.

Change-Id: Ia7d1741fc8d829dd14e5c68f21fa99282eddbeab
Reviewed-on: https://code.wireshark.org/review/299
Reviewed-by: Evan Huus <eapache@gmail.com>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Fix Called function pointer is null (null dereference) found by Clang

../../asn1/h248/packet-h248-template.c:1222:31: warning: Value stored to 'prop' is never read
        if (!prop->dissector) prop = &no_param;

Change-Id: I6d380fbb5fef9dc548385b0b470aea1cb3c34df1
Reviewed-on: https://code.wireshark.org/review/301
Reviewed-by: Evan Huus <eapache@gmail.com>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Add some simple ISAKMP heuristics

Hopefully fixes bug 9800.

Change-Id: I69e1a0e39763a6e25eb18aed6b4a6a6217e22d14
Reviewed-on: https://code.wireshark.org/review/312
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Reviewed-by: Evan Huus <eapache@gmail.com>
Add note to .gitignore on how to ignore locally-specific files

Also, this removes a couple locally-specific files I had previously added.

Change-Id: Ib93e0dc5aeb062321e47f77a084b0581f87046c6
Reviewed-on: https://code.wireshark.org/review/315
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Reviewed-by: Evan Huus <eapache@gmail.com>
Documentation updates

Change-Id: I6bd7fa40726fe7ffd68b9341c640874f2a0f1c7c
Reviewed-on: https://code.wireshark.org/review/314
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Reviewed-by: Christopher Maynard <Christopher.Maynard@gtech.com>
Reviewed-by: Evan Huus <eapache@gmail.com>
[Automatic manuf, services and enterprise-numbers update for 2014-02-23]

Change-Id: Ib8cee06ff9420f16566696ca7dd0efc97036c7dc
Reviewed-on: https://code.wireshark.org/review/316
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Remove deprecated TVB APIs

Change-Id: I87216c3bd2061c12ce486c752d4381ab722db95e
Reviewed-on: https://code.wireshark.org/review/328
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
Fix dissection of BCD numbers

Do not use of tvb_get_string(): what we really want is the byte string, not an ASCII string

Change-Id: I8b9a8b7ccacbdaf6d9525771ff8ed883ba01ad34
Reviewed-on: https://code.wireshark.org/review/329
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
NAS EPS: fix dissection of CS service notification message

Fixes bug 9789

Change-Id: I26ed1e9d8bb5b662af97d19f64b5f4b39374a5ee
Reviewed-on: https://code.wireshark.org/review/330
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>