working on attribute check