shouldn't we include regex for optional whitespace in the attribute?