remove dynamic finder

Change-Id: I0002aec2679cf3f7dbefddbef458c53c8fb1d013
Reviewed-on: https://gerrit.instructure.com/37719
Reviewed-by: James Williams  <jamesw@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
fix ArgumentError usage

came across this while debugging once-ler stuff ... this way you get an
ArgumentError instead of `NoMethodError: undefined method `ArgumentError'`

Change-Id: Idb994326e1fb376f30948e000be1a23c7e5301a8
Reviewed-on: https://gerrit.instructure.com/37843
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Cody Cutrer <cody@instructure.com>
Product-Review: Jon Jensen <jon@instructure.com>
QA-Review: Jon Jensen <jon@instructure.com>
set up test shards before the top-most group

create our test shards a little earlier in the process (but still keep
things hidden from non-sharded groups/specs). this way, CREATE/DROP SCHEMA
and friends will definitely happen outside of a transaction (e.g. if you
are using once-ler)

this makes switchman + once-ler waaaay more compatible, as it's kind of
luck of the draw right now (i.e. whether or not the first inclusion of
RSpecHelper happens in a :once'd block; if it does, everything asplodes)

Change-Id: Id4a23cb70040386af35b0e1ef5f956e703c78971
Reviewed-on: https://gerrit.instructure.com/37852
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Cody Cutrer <cody@instructure.com>
Product-Review: Jon Jensen <jon@instructure.com>
QA-Review: Jon Jensen <jon@instructure.com>
preapre for upgrade to rspec 3

Change-Id: I551661c2d088f70588fcdd5b170f54fd71fb0f85
Reviewed-on: https://gerrit.instructure.com/37872
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: James Williams  <jamesw@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Convert specs to RSpec 2.99.1 syntax with Transpec

This conversion is done by Transpec 2.3.6 with the following command:
    transpec --no-parens-matcher-arg

* 450 conversions
    from: obj.should
      to: expect(obj).to

* 423 conversions
    from: == expected
      to: eq(expected)

* 42 conversions
    from: obj.should_not
      to: expect(obj).not_to

* 8 conversions
    from: lambda { }.should
      to: expect { }.to

* 7 conversions
    from: pending
      to: skip

* 5 conversions
    from: > expected
      to: be > expected

* 3 conversions
    from: < expected
      to: be < expected

* 2 conversions
    from: lambda { }.should_not
      to: expect { }.not_to

* 1 conversion
    from: be_false
      to: be_falsey

* 1 conversion
    from: describe 'some model' { }
      to: describe 'some model', :type => :model { }

For more details: https://github.com/yujinakayama/transpec#supported-conversions

Change-Id: I3c45862e99ea8ca732650667b1eb301704e1c195
Reviewed-on: https://gerrit.instructure.com/37873
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Jon Jensen <jon@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
add a spec exercising has_many :through #include? cross-shard

Change-Id: Ie9704ff05691c94a8a9784fa08b364046588b68b
Reviewed-on: https://gerrit.instructure.com/34948
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: James Williams  <jamesw@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>