Hi Ariel,

I have changed to code to minimize the loops. The only way to reduce code
further is with method parameters and I don't know how or if they get
optimized so if you think it is still to complex, I will just put it back
the old way and and a conditional in the main loop.

Thanks,

-Walter


On Fri, Mar 28, 2014 at 5:46 PM, aweisberg <notifications@github.com> wrote:

> In src/frontend/org/voltcore/network/VoltNetwork.java:
>
> >          try {
> >              while (m_shouldStop == false) {
> >                  try {
> > -                    while (m_shouldStop == false) {
>
> Duplicating the loop is way too much copy pasta to remove one if
> statement. Pulling the estimate time stuff into a separate function makes
> sense though. I would push the condition for different key set types into
> an invokeCallbacks wrapper.
>
> --
> Reply to this email directly or view it on GitHub<https://github.com/VoltDB/voltdb/pull/1252/files#r11087128>
> .
>



-- 

*Walter Weiss,* Software Engineer
*VoltDB, Inc.*
*E:* wweiss@voltdb.com
*O:* +1 978.528.0592
*M:* +1 978.204.4745
www.voltdb.com <http://voltdb.com>
Follow VoltDB on Twitter <https://twitter.com/voltdb>,
Facebook<https://www.facebook.com/VoltDB?sk=wall>,
and LinkedIn <http://www.linkedin.com/company/voltdb>