ChangeScreen2: Respect user preference for unified diff view

Change-Id: I6ca7c3957bc111bb1a6bc8a73c607fbe75db6ea5
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
Document more details about the deploy configuration for Maven Central

Change-Id: Ie1e3a4d0f3ca8a7e3a36efd729caac3eb6ed7121
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
Release docs: Describe in more details how to publish to Maven Central

Change-Id: I69d335cbd6ba192b716782ed9379716c8a37861a
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
Merge "ChangeScreen2: Respect user preference for unified diff view" into stable-2.9
Update archetype version in plugin documentation to 2.9

When 2.9 is released plugin developers should be able to copy and
paste the archetype command from the plugin documentation. For this
the version should match the released version. The command will work
only after the 2.9 plugin artifacts have been published to Maven
Central.

Change-Id: I4188c3740536f31eb49be2091cc89630da6cda96
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
Release documentation: Add URL to Gerrit artifacts on Maven Central

Released artifacts first appear in the Sonatype releases repository
and are only then replicated to Maven Central. Clarify this in the
release documentation.

Change-Id: Ie50a41685222a4423d9fde727e5af29691ca2c8d
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
Update repository in pom.xml of plugin archetypes

The plugin artifacts are no longer published to the Google Cloud
Storage but to Maven Central.

To reference released artifacts from Maven Central it is not necessary
to specify a repository in the pom.xml. This is because by default
Maven tries to find any artifact in Maven Central.

The Gerrit snapshots artifacts are now published to the Sonatype
snapshot repository [1], hence this repository must be specified in
the pom.xml if snapshot artifacts are referenced.

[1] https://oss.sonatype.org/content/repositories/snapshots/

Change-Id: Iac7d1b6e6957a9bcc43a42fab9d85dc111d46246
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
Merge "Release documentation: Add URL to Gerrit artifacts on Maven Central" into stable-2.9
Apache/mod_jk/web server: Describe ForwardURICompatUnparsed option

Change-Id: I66cf0f1c1ec19a76a6e392ac2c5ddb98b374ffc3
Review UI docs: Move sentence about download icon to right place

The description of the download icon in the side-by-side diff view
should come directly after the description of the patch set selection
because in the UI both elements are right next to each other. The
description of the download icon got accidentally moved down by
inserting a new paragraph in [1].

[1] https://gerrit-review.googlesource.com/57014

Change-Id: I10d3b88c0a76766ba10d52a902c91c0b5dad6350
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
Review UI docs: Add screenshot of side-by-side diff with renamed file

Change-Id: I276f47b8d855db2ea1f961c172c841618ed2096e
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
Update replication plugin

- Fix double packaging of commons-io

Change-Id: Ibc85006ee74dc4e29b9e90ad9b12139fc82eb7cf
Doc: Fix typo

Change-Id: Id1a266a741fa2e72d2e653e60844184540787934
MergeabilityChecker: Fix isStale() optimization

Change copy constructor is missing to copy the value of lastSha1MergeTested.
MergeabilityChecker relies on this value to be set to skip unnecessary
mergeability status reevaluation and no-op database and index operations.

Change-Id: Id4ef8388b026a68d5f1d97ee89c526a04797c5dc
Fix consultRules so that it does not bail out on RuntimeException

This problem was causing internal server error in Gerrit GUI on browsing
open changes in case one or more projects had broken rules.pl in meta
config.

Change-Id: Ib1395a5d48abd0150a9b2e0c3680cb39ae186f1a
Signed-off-by: Eryk Szymanski <eryksz@gmail.com>
Cherry-pick: Bump database row version to invalidate ETag cache

When a change is cherry-picked from one branch to another, the following
message is added to the source change:

Patch Set 1: Cherry Picked
This patchset was cherry picked to branch <foo> as commit <bar>

and should be shown when the source change is opened after cherry-pick
action.  While this works as expected on the old change screen, it
doesn't work on new change screen because of ETag caching feature:
change itself isn't changed and NOT_MODIFIED (304) response code is
sent back to client, preventing new rendering.

Remedy this by bumping database row version, like it is already the case
on add/remove reviewers action.

Bug: issue 2710
Change-Id: I0aeaf87fca522a79de0d025384d8b62078e4f0c8
Merge "Fix consultRules so that it does not bail out on RuntimeException" into stable-2.9
ChangeMergeQueue: Fix race condition

To the multiple triggers of submit action belong:

* ChangeMergeQueue.merge() method called from the UI
* ChangeMergeQueue.schedule() method called by background
ReloadSubmitQueueOp

active map in ChangeMergeQueue acts as a guard for submit job
scheduling. However schedule() ignores the fact that the submit
processing was already started for a specific branch and double
submit action is scheduled.

Specifically for cherry-pick submit strategy that cannot end
good and fails with database constraints violation or similar,
depending on the underlying database implementation.

Guard the background scheduling similar to the UI scheduling.

Defining unique index prevents the database corruption: [1], [2]
but not the collision between manual and background merge jobs.

[1] http://paste.openstack.org/show/83883
[2] http://paste.openstack.org/show/83888

Bug: issue 2034
Bug: issue 2383
Bug: issue 2702
Change-Id: I5b23f9d481351280e26412b82b525947338d9c00
Add missing 'link:' in 2.8.5 release notes

Change-Id: I6268999ab31dd26b829b650d98d076f7223868bd
Release notes for Gerrit 2.8.6

Change-Id: I72451095da8ee6973fbe140edbf9954420b2b795