unit test this?