Converted many sprintf calls to snprintf.

Converted most of the easy calls of sprintf to snprintf. This is good, because most compilers including MSVC have sprintf deprecated. We have the warnings disabled with the pragmas:
#pragma warning(disable : 4996)

I was concerned that it would slow things down. But I tested it on Windows 8 and Ubuntu, with no difference in CPU or ram utilization.
Excellent observations.

The point was not to fix any potential buffer overflows. It was just an intermediary step to removing all the unsafe/deprecated stuff and replacing it with proper C++11 things like std::array, std::vector, std::copy, std::string, et cetera.

I tried doing that before. But it was a huge set of commits, that was impossible for other people to review. Plus every commit into master by someone else, was a huge merge conflict that I had to merge back by hand.

What do you recommend going forward with?