LPS-44010 We need to deprecate this method because it's protected and there are plugins that are extending this class and overriding this method.
LPS-44593 We don't need to infer the className and classPK for doing the permission checking based on the order of the method addPersistedSubscriber because that's ugly and very fragile. We should do the permission check based on the className and classPK attributes of the SubscriptionSender object. In order to keep backwards compatibility we have deprecated some methods by extracting the logic to a private method and in the future we can just get rid of the deprecated methods and replace them with the code in the private methods.
LPS-44593 In wiki and message boards we are checking the containers permission (The subscribe permission). Should it be done in all entities with containers such DL, DLFET, Journal or Bookmarks??
LPS-44593 Use get* instead of fetch* because if the entity doesn't exist it should throw an exception
LPS-44593 Pass the object to avoid one extra query
LPS-44593 I don't see in which case we may have a fileVersionId as a classPK
LPS-44593 We don't need to do permission checking on DLFileEntryType because it would only check for the Subscribe permission and this is not supported (we don't have any SUBSCRIBE permission on DLFileEntryType)
LPS-44593 Run ant format-source
LPS-44593 Let's make it protected, just in case someone needs to override it
LPS-44010 LPS-44593 Why deprecate it? Let's just use it?
LPS-44593 Auto SF
LPS-45043 Remove unthrown exception
LPS-45043 Regen
Test fixes: journal and document library subscriptions
Test fixes: changed official dumpster version to a forked one (https://github.com/rjo1970/dumbster)
Test Fixes - SF
Test Fixes - Add author
Test Fixes - SF
LPS-45107 Fix test
LPS-45107 SF