Because I hate AutoPtr's (not just our implementation, but the entire idea)
so I try to get rid of them as soon as possible ;-)

Actually, the same idea occurred to me... especially after the second time
of forgetting to delete the vectors!  ;-)

This is a good opportunity to use the new ability to modify files directly
on GitHub and create a new commit - let me try...


On Wed, Jan 29, 2014 at 11:50 AM, Benjamin S. Kirk <notifications@github.com
> wrote:

> In src/systems/equation_systems.C:
>
> >
> > -  // Gather the distributed node_conn arrays in the case of
> > -  // multiple processors.
> > -  this->comm().sum(node_conn);
> > +  // Create a NumericVector to hold the parallel solution
> > +  NumericVector<Number> & parallel_soln = *(NumericVector<Number>::build().release());
>
> Why not catch these in an AutoPtr<> rather than dangeroulsy releasing them
> here and requiring the manual delete below?
>
> Why not
>
> AutoPtr<NumericVector<Number> > parallel_soln_ptr = NumericVector<Number>::build();NumericVector<Number> &parallel_soln = *parallel_soln_ptr;
>
> --
> Reply to this email directly or view it on GitHub<https://github.com/libMesh/libmesh/pull/190/files#r9278579>
> .
>