orangefs: consolidate xattr code in xattr.c

Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Mike Marshall <hubcap@omnibond.com>
orangefs: xattr consolidation, part 2

Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Mike Marshall <hubcap@omnibond.com>
orangefs: cleanup pvfs2_inode_getxattr

Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Mike Marshall <hubcap@omnibond.com>
orangefs: cleanup pvfs2_inode_setxattr

Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Mike Marshall <hubcap@omnibond.com>
orangefs: remove pvfs2_removexattr

This function is unused, removal happen through the xattr handlers instead.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Mike Marshall <hubcap@omnibond.com>
orangefs: cleanup pvfs2_inode_removexattr

Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Mike Marshall <hubcap@omnibond.com>
orangefs: cleanup pvfs2_listxattr

Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Mike Marshall <hubcap@omnibond.com>
orangefs: remove permission checks from xattr handlers

The Linux VFS already does permission checking for xattrs, so none of
this is needed.  The only exception is that orangefs didn't allow
xattrs on directories with the sticky bit, something that no other
filesystem does, and for which I can't find a rationale.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Mike Marshall <hubcap@omnibond.com>
orangefs: remove zero-length xattr checks

The VFS already handles this for us.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Mike Marshall <hubcap@omnibond.com>
orangefs: consolidate a little more xattr get/set code

Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Mike Marshall <hubcap@omnibond.com>
orangefs: beautify a few lines, no functional change

Signed-off-by: Mike Marshall <hubcap@omnibond.com>