That's why you should create individual commits that mention these kinds of
details, not one mass change commit that is difficult to accept while there
are still issues and conveys very little information about why certain
changes are being made, especially when looking back at the commits.



On Thu, May 8, 2014 at 5:30 PM, Anton <notifications@github.com> wrote:

> In classes/Kohana/Response.php:
>
> > @@ -503,10 +488,12 @@ public function send_file($filename, $download = NULL, array $options = NULL)
> >  		// Send all headers now
> >  		$this->send_headers();
> >
> > -		while (ob_get_level())
> > +		// Flush all output buffers
> > +		$levels = ob_get_level();
>
>  If you enable zlib.output_compression then level count will be increased
> by 1 and then this code will just freeze your script.
> http://ru2.php.net/manual/ru/function.ob-end-flush.php#103387
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/kohana/core/pull/487/files#r12434846>
> .
>