(PUP-2755) Mark function stubs as rvalue

The function stubs that are left in place to allow "puppet doc" to
document the new functions were supposed to issue an error when they are
used under "--evaluate current", but you couldn't call them in their
normal fashion because they were not specified as :rvalue functions,
which they used to be. This puts the rvalue flag back on so that if they
are called then they can produce the intended error message.
Merge branch 'pr/2765'

* pr/2765:
  (PUP-2755) Mark function stubs as rvalue
  (PUP-2791) Update docs for EPP syntax
  (maint) Fix stylistic issues from review of PUP-2755
  (PUP-2755) Remove special handling of iterative functions / cleanup
  (maint) Fix stylistic issues from review
  (maint) Remove dead test code
  (maint) Add 3x function doc stub for 4x function with
  (maint) Update function 'with's documentation with an example
  (maint) Add 3x function doc stub for 4x function slice
  (maint) Add 3x function doc stub for 4x function reduce
  (maint) Add 3x function doc stub for 4x function match
  (maint) Add 3x doc function stub for 4x function map
  (maint) Add 3x function doc stub for 4x function filter
  (maint) Add 3x function doc stub for 4x function each
  (maint) Add doc stub for 4x function assert_type
  (PUP-2755) Fix issues after changes from PUP-514
  (maint) Add leaky local scope tests
  (PUP-2755) Move iterative functions to the new API
  (PUP-1057) Remove the function stubs for collect and select
Merge remote-tracking branch 'upstream/master' into puppet-4

* upstream/master: (26 commits)
  (PUP-2755) Mark function stubs as rvalue
  (PUP-2791) Update docs for EPP syntax
  (maint) Fix stylistic issues from review of PUP-2755
  (PUP-2755) Remove special handling of iterative functions / cleanup
  (maint) Fix stylistic issues from review
  (maint) Remove dead test code
  (maint) Add 3x function doc stub for 4x function with
  (maint) Update function 'with's documentation with an example
  (maint) Add 3x function doc stub for 4x function slice
  (maint) Add 3x function doc stub for 4x function reduce
  (maint) Add 3x function doc stub for 4x function match
  (maint) Add 3x doc function stub for 4x function map
  (maint) Add 3x function doc stub for 4x function filter
  (maint) Add 3x function doc stub for 4x function each
  (maint) Add doc stub for 4x function assert_type
  (maint) Refactor EvaluatingParser to use IssueReporter
  (maint) Disable future parser warnings based on :disable_warnings
  (PUP-2557) Issue deprecation warning for AST::Node inheritance
  (PUP-2755) Fix issues after changes from PUP-514
  (maint) Add leaky local scope tests
  ...
Merge pull request #2666 from ffrank/maint/eliminate-type-doc-todos

(maint) Resolve some documentation TODOs in Puppet::Type
(PUP-2727) Make new keywords acceptable as attribute names.

Puppet allows keywords as attribute names in defines and
parameterized classes. This was missing for the added keywords:
* FUNCTION
* ATTR
* PRIVATE
* TYPE

Which caused a clash with existing types.

This commit adds the new keywords to the list of accepted words
in the grammar.
(PUP-2758) Add micro benchmark(s) task

This adds a benchmark that runs a series of puppet manifests that
are measured individually for parse and evaluation time. Each
manifest is measured 100x each for parse and evaluation. The benchmark
total time includes running all of them (including overhead of
measuring the details). Details are output as average of all runs
per detail where parsing and evaluating is output as separate entries.

The sample file written is for the total average.
(PUP-2758) Add passing arguments (warm_up and detail) to Benchmarker.run

Arguments are needed to be able to run one detail of a benchmark.
The evaluations benchmark makes use of this, all others ignore the
arguments.
(maint) Correct typo in loader helper class and add tests

Loading the same function multiple times from modules caused
an error because of a typo in NamedEntry. This adds tests for the
helper classes basic functionality, and adds tests that loaders indeed
can load a function more than once.

This also corrects error handling (yet another typo) when a function was
redefined (the wrong method was called).
(PUP-2758) Add calls to 3x, 4x, and namspace 4x functions to evaluations

This adds additional benchmarks for function calls using 3x calls,
4x calls in global namespace, and name spaced to a module.

A simple assert_type benchmark is also added (one simple type check).
Merge pull request #2748 from hlindberg/PUP-2727_keywords-clash-with-attributes

(PUP-2727) Make new keywords acceptable as attribute names.
(PUP-2758) Generate tasks with arguments defined by benchmark

This makes it possible for a benchmark scenario that wants
additional details to run a smaller portion of the benchmark to
configure these by defining a class called BenchmarkerTask (currently
only used by the evaluations benchmark). The separation from the
Benchmarker class is that this class is loaded when rake generates a
list of tasks, and it is not wanted to load each full benchmark in turn
to generate this list. (Over time, the BenchmarkerTask can be expanded
on to perform other task generation duties).

It is now possible to run all of the evaluations benchmarks,
profile all, run one particular micro benchmark, or just its parse or
evaluation part by suffixing the name with _parse or _eval. As an
example rake benchmark:evaluations:run[assert_type_eval] runs only the
evaluation part of the assert_type micro benchmark in evaluations. (This
is especially useful when running profiling.

For profiling, the parameter warm_up_runs is always included.
(PUP-2758) Add benchmarks empty catalog, and defined_types for future

This adds benchmark that runs the defined_types benchmark for the future
parser (everything else is the same).
A benchmark is also added to measure the overhead of compiling a
catalog with minimal (almost nothing) content (i.e. a command line
puppet apply scenario).
(PUP-2738) FFI from_string_to_wide_string block

 - MemoryPointer from_string_to_wide_string previously allocated a
   new MemoryPointer instance but didn't force callers to scope / free
   it.  This allowed the Ruby runtime to clean it up on GC, but we
   prefer to force callers to use a block form, to clean up the
   unmanaged memory when the variable is no longer needed.  Refactor
   the method to yield the ptr.
 - Since the ptr is no longer valid after the block yields, return nil
   from the method
(PUP-2738) Puppet::Util::Windows::User refactor

  - Presently `logon_user` raises an exception or returns the error code
    returned by `CloseHandle`.  Change this to return `true` if the
    method executes without error.
  - This also affects the `load_profile` method and the `password_is?`
    method.  `load_profile` previously returned the `logon_user` return
    value from the outer block, so now returns `true` upon success, or
    will raise an error upon failure
(PUP-2738) open_symlink should wide_string once

 - open_symlink is the only caller for create_file, and create_file
   already calls wide_string on the first parameter.  Remove
   unnecessary wide_string call perfomed in open_symlink
(PUP-2738) Puppet::Util::Windows::File FFI cleanup

 - Break resolve_symlink into an additional helper to simplify memory
   usage / cleanup.  Each time an FFI::MemoryPointer is encountered,
   it's cleaned up immediately after use. Structure code to ensure that
   a REPARSE_DATA_BUFFER is returned from resolve_symlink rather than
   a FFI::MemoryPointer
 - Ensure that Puppet::Util::Windows::File.resolve_symlink return value
   is given default, and closed on inside block to prevent incorrect
   return value.
(PUP-2738) Puppet::Util::Windows::Process FFI clean

 - Refactor wait_process so that the FFI::MemoryPointer for the exit
   code is cleaned up immediately after use.  Note that we capture the
   exit_status within the block, and return it outside of the block
 - Fix bug in Puppet::Util::Windows::Process.process_privilege_symlink?
   that could result in the wrong value being returned.
 - Fix bug in Puppet::Util::Windows::Process.elevated_security?
   that could result in the wrong value being returned.
(PUP-2738) Use block form of FFI::MemoryPointer

 - Existing uses of FFI::MemoryPointer rely on Ruby GC to perform
   non-deterministic memory cleanup.  In an effort to reduce memory
   consumption, use the block form of FFI::MemoryPointer to call free
   on pointers as soon as they're no longer needed.
 - Ensure that we don't use non-local return's anywhere, due to their
   potential dangerous / unexpected behavior.  When inside blocks,
   store off return values in a separate variable to be returned
   outside the block.  When values are only used inside yields, and the
   corresponding unmanaged memory has been freed, return nil outside
   the block.
(PUP-2738) Windows utils appropriate return values

 - Puppet::Util::Windows::File.open_symlink was previously returning
   the integer result of CloseHandle, which was undesireable.  Assume
   the token is always used in a block, so return nil from the method.
 - Puppet::Util::Windows::File.readlink was being a bit dangerous, and
   performing a non-local return within a block.  Use a closure instead
   to capture the return value of resolve_symlink, return outside block.
 - Puppet::Util::Windows::Process.open_procss_token had the same issue
   as open_symlink, and has been changed to return nil.
(PUP-2738) Move CloseHandle -> FFI::WIN32

  - CloseHandle is an API used frequently, so move it to a shared
    definition inside FFI::WIN32.  Remove extraneous definitions and
    update call sites.