Following up on r1603485, make the 'db/current' parsing within the
svn_fs_fs__read_current() routine stricter.

* subversion/libsvn_fs_fs/util.c
  (svn_fs_fs__read_current): Expect a newline after the revision number
    for new FS formats and after the next-copy-id for old formats.  A well-
    formed 'db/current' file always includes a trailing newline.  Raise an
    error when it is absent.


git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1603605 13f79535-47bb-0310-9956-ffa450edef68
Fix JavaHL tests.

* subversion/bindings/javahl/src/org/apache/subversion/javahl/ClientNotifyInformation.java
  (ClientNotifyInformation.Action): Add missing enumeration constants.


git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1603616 13f79535-47bb-0310-9956-ffa450edef68
Resolve the issue for which I added a regression test in r1603497.

* subversion/libsvn_client/commit.c
  (post_process_commit_item): Add svn_error_tracer
  (post_process_no_commit_item): New function like post_process_commit_item,
    but just handling the no-commit operations.
  (svn_client_commit6): Only call post_process_commit_item on items that we
    are really committing, and post_process_no_commit_item on everything else.

* subversion/tests/cmdline/lock_tests.py
  (commit_file_unlock): Update expected result to no longer
    expect an invalid bump.
  (lock_commit_bump): Remove XFail marker.


git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1603617 13f79535-47bb-0310-9956-ffa450edef68
* subversion/libsvn_client/commit.c
  (svn_client_commit6): Following up on r1603617, remove SVN_DBG().


git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1603619 13f79535-47bb-0310-9956-ffa450edef68
Enhance the regression test added by Bert in r1603497 to check both revs.

* subversion/tests/cmdline/lock_tests.py
  (lock_commit_bump): Add explicit check for both 'Revision' and
    'Last Changed Revision' not being bumped, as the implicit check
    performed after the commit only checks the first one.


git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1603750 13f79535-47bb-0310-9956-ffa450edef68
* subversion/tests/svn_test_main.c
  (cl_options): Improve documentation of --srcdir option. The meaning of this
   option was defined in a circular way (as in "--srcdir means source dir").


git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1603789 13f79535-47bb-0310-9956-ffa450edef68
Fix fallout from r1537147 and other revision which involved changes to
the way the --srcdir option is handled in the C tests.

Originally, this option was used only by config-test.c and was required,
ie. the test failed if the option wasn't given (i.e. opt.srcdir == NULL).
Since r1537147 these tests would crash if no --srcdir option was given.
Some tests in checksum-test.c and repos-test.c have since started using
the value of --srcdir, also without checking for NULL.

Add a new helper function svn_test_get_srcdir() for these tests, which
falls back to the current working directory if --srcdir isn't given.
This allows tests to pass if invoked from within their directory:
  cd subversion/tests/libsvn_subr && ./config-test

The test runner has always been passing --srcdir to C tests, so the
standard 'make check' procedure wasn't affected by this problem.

* subversion/tests/libsvn_repos/repos-test.c
  (test_config_pool): Use svn_test_get_srcdir().

* subversion/tests/libsvn_subr/checksum-test.c
  (zlib_expansion_test): Use svn_test_get_srcdir().

* subversion/tests/libsvn_subr/config-test.c
  (get_config_file_path): New helper function which uses
   svn_test_get_srcdir() to build the test configuration file's path.
  (test_text_retrieval, test_boolean_retrieval,
   test_has_section_case_insensitive, test_has_section_case_sensitive,
   test_has_option_case_sensitive, test_stream_interface,
   test_read_only_mode): Use get_config_file_path().

* subversion/tests/svn_test.h
  (svn_test_get_srcdir): Declare.

* subversion/tests/svn_test_main.c
  (svn_test_get_srcdir): New helper function to obtain the value of
   the --srcdir option.


git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1603816 13f79535-47bb-0310-9956-ffa450edef68
* tools/dev/unix-build/Makefile.svn: Fix BDB download URL in my custom
   build script.


git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1603821 13f79535-47bb-0310-9956-ffa450edef68
Tweak a bit of code for improved documentation. No functional changes.

* subversion/libsvn_subr/win32_crashrpt.c
  (convert_wbcs_to_utf8): Rename static function to...
  (convert_wbcs_to_ansi): ... this, to document what it really does.
    As this is the desired behavior, all we have to do is...
  (write_module_info_callback,
   format_value): Update callers.


git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1603826 13f79535-47bb-0310-9956-ffa450edef68
On the svn-auth-x509 branch, merge outstanding changes from trunk.


git-svn-id: https://svn.apache.org/repos/asf/subversion/branches/svn-auth-x509@1603833 13f79535-47bb-0310-9956-ffa450edef68
On the svn-auth-x590 branch, fix the build by removing calls to a
non-existent function.

* subversion/libsvn_subr/x509parse.c
  (_x509parse_crt_1): x509_free() was removed, stop calling it.


git-svn-id: https://svn.apache.org/repos/asf/subversion/branches/svn-auth-x509@1603835 13f79535-47bb-0310-9956-ffa450edef68